Add tags field to Firestore Database resource.
#13670
Conversation
|
Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: see go/terraform-auto-test-runs to set up automatic test runs. @SirGitsalot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
modular-magician
added
the
awaiting-approval
| {"123/environment" : "tagValues/444"} | ||
| Inconsistent format is not supported. | ||
| For example, the following is invalid. | ||
| {"tagKeys/333" : "tagValues/444", "123/env" : "prod"} |
There was a problem hiding this comment.
Can you also add the text from mmv1/products/filestore/Instance.yaml - it's pertinent to Terraform users
There was a problem hiding this comment.
I copied most of the text from filestore/instance.yaml, but I think their description to the format is not completely correct. Based on tags, I think we can take 2 different formats (1) tagKeys/key_id: tagValues/value_id (2) namespacedName of key: short name of value. (They cannot be mixed up in the map.)
mmv1/templates/terraform/examples/firestore_database_with_tags.tf.tmpl
Outdated
Show resolved
Hide resolved
This commit adds support for the
tagsfield to the Firestore Database resource. Thetagsfield is amap<string, string>. This allows users to perform database actions and setting tag bindings at the same time.