Skip to content

location attribute incorrectly marked as optional for cross-cloud interconnect #13665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

abhijeetkjha-google
Copy link
Contributor

@abhijeetkjha-google abhijeetkjha-google commented Apr 14, 2025

compute: marked `location` field as required in `google_compute_interconnect` resource

On the resource 'google_compute_interconnect', the attribute 'location' is incorrectly marked as optional, even for cross-cloud interconnect. It needs to be required.

https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/compute_interconnect
location - (Optional) URL of the InterconnectLocation object that represents where this connection is to be provisioned. Specifies the location inside Google's Networks, should not be passed in case of cross-cloud interconnect.

It should be marked as a required field, the customer has to provide a location for all interconnects regardless of whether it's cross cloud or not.

@github-actions github-actions bot requested a review from BBBmau April 14, 2025 08:30
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: see go/terraform-auto-test-runs to set up automatic test runs.

@BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant