Add custom performance support for netapp storage pools

[sahil-mahajan-google]

netapp: added `custom_performance_enabled`, `total_throughput_mibps`, and `total_iops` fields to `google_netapp_storage_pool` resource

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: see go/terraform-auto-test-runs to set up automatic test runs.

@shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 13 insertions(+))
google-beta provider: Diff ( 4 files changed, 170 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 30 insertions(+))

Missing doc report (experimental)

The following resources have fields missing in documents.

• google_netapp_storage_pool
  • Expected Document Path: /website/docs/r/netapp_storage_pool.html.markdown
  • Fields: [custom_performance_enabled total_iops total_throughput_mibps]

[modular-magician]

Tests analytics

Total tests: 24
Passed tests: 23
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• netapp

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccNetappStoragePool_customPerformanceStoragePoolCreateExample_update

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccNetappStoragePool_customPerformanceStoragePoolCreateExample_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[shuyama1]

Test failed with error:

resource_netapp_storage_pool_test.go:375: Step 1/2 error: Error running apply: exit status 1
        
        Error: Error creating StoragePool: googleapi: Error 400: Zone is required for zone-redundant storagePool.
        
          with google_netapp_storage_pool.test_pool,
          on terraform_plugin_test.tf line 26, in resource "google_netapp_storage_pool" "test_pool":
          26: resource "google_netapp_storage_pool" "test_pool" {

Could you follow the internal contribution guide to get your GH account registered to automatically trigger tests for your PRs. Thanks!

[sahil-mahajan-google]

Added the fix for test to pass. Can it be retried?

[shuyama1]

Could you follow the internal contribution guide to get your GH account registered to automatically trigger tests for your PRs. Thanks!

Thanks! Triggered the test. Meanwhile, could you please follow the internal contribution guide to get your GH account registered to automatically trigger tests for your PRs. Thanks!

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 13 insertions(+))
google-beta provider: Diff ( 4 files changed, 170 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 30 insertions(+))

Missing doc report (experimental)

The following resources have fields missing in documents.

• google_netapp_storage_pool
  • Expected Document Path: /website/docs/r/netapp_storage_pool.html.markdown
  • Fields: [custom_performance_enabled total_iops total_throughput_mibps]

[modular-magician]

Tests analytics

Total tests: 24
Passed tests: 23
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• netapp

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccNetappStoragePool_customPerformanceStoragePoolCreateExample_update

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccNetappStoragePool_customPerformanceStoragePoolCreateExample_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 13 insertions(+))
google-beta provider: Diff ( 4 files changed, 151 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 30 insertions(+))

[modular-magician]

Tests analytics

Total tests: 25
Passed tests: 24
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• netapp

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccNetappStoragePool_customPerformanceStoragePoolCreateExample_update

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccNetappStoragePool_customPerformanceStoragePoolCreateExample_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test