Skip to content

Add tags field to Metastore Federation for TagsR2401 #13662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rajeshgupthar
Copy link
Contributor

Add tags field to federation resource to allow setting tags on federation resources at creation time.
Part of b/367307391

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

metastore: added `tags` field to `metastore_federation` to allow setting tags for federations at creation time

Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: see go/terraform-auto-test-runs to set up automatic test runs.

@roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 314 insertions(+), 99 deletions(-))
google-beta provider: Diff ( 6 files changed, 314 insertions(+), 99 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 17 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field deletion_protection within resource google_dataproc_metastore_federation was either removed or renamed - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_dataproc_metastore_federation (7 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dataproc_metastore_federation" "primary" {
  tags = # value needed
}

Missing doc report (experimental)

The following resources have fields missing in documents.

  • google_dataproc_metastore_federation
    • Expected Document Path: /website/docs/r/dataproc_metastore_federation.html.markdown
    • Fields: [tags]

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • dataprocmetastore
#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccMetastoreFederation_tags
    🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

Copy link
Contributor

@roaks3 roaks3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just adding an initial note that the checks will need to be resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants