container: allow updating windows_node_config in place #13658
Conversation
Signed-off-by: drfaust92 <[email protected]>
| @@ -718,7 +718,6 @@ func schemaNodeConfig() *schema.Schema { | |||
| "osversion": { | |||
| Type: schema.TypeString, | |||
| Optional: true, | |||
| ForceNew: true, | |||
There was a problem hiding this comment.
actual change, everything else is fmt
|
Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: see go/terraform-auto-test-runs to set up automatic test runs. @roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
modular-magician
added
the
awaiting-approval
There was a problem hiding this comment.
Do you think we might be able to add a plan check to TestAccContainerNodePool_withWindowsNodeConfig, as specified here? That would be nice to confirm the update in place, since the test was passing before.
Otherwise the change LGTM
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.
tests and update logix exists, but the forcenew is extraneous. tested locally with flag and before to validate behavour change and that node pool is not recreated. other changes is just fmt