Skip to content

container: allow updating storage_pools #13657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DrFaust92
Copy link
Contributor

@DrFaust92 DrFaust92 commented Apr 12, 2025

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

container: allowed in-place update for `storage_pools` field in `google_container_node_pool` resource
container: allowed in-place update for `node_pool.node_config.storage_pools` field in `google_container_cluster` resource

Update func already implemented, but the force new on storage_pools was kept erroneously

Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: see go/terraform-auto-test-runs to set up automatic test runs.

@zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions bot requested a review from zli82016 April 12, 2025 20:51
@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests service/container and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Apr 12, 2025
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 1 deletion(-))
google-beta provider: Diff ( 1 file changed, 1 deletion(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 230
Passed tests: 219
Skipped tests: 11
Affected tests: 0

Click here to see the affected service packages
  • container

🟢 All tests passed!

View the build log

@zli82016
Copy link
Member

Copy link
Member

@zli82016 zli82016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add more test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants