container: allow updating accelerators

[DrFaust92]

Release Note Template for Downstream PRs (will be copied)

container: allow update in place for `guest_accelerator`

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: see go/terraform-auto-test-runs to set up automatic test runs.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[DrFaust92]

this will recreate when guest_accelerator is removed as there no method to remove via API (I tried thoroughly) but will allow updating if changes to nested args are made

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 80 insertions(+), 43 deletions(-))
google-beta provider: Diff ( 2 files changed, 80 insertions(+), 43 deletions(-))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Field node_config.guest_accelerator transitioned from optional+computed to optional google_container_cluster - reference
• Field node_config.guest_accelerator transitioned from optional+computed to optional google_container_node_pool - reference
• Field node_pool.node_config.guest_accelerator transitioned from optional+computed to optional google_container_cluster - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_container_cluster (450 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_container_cluster" "primary" {
  node_config {
    guest_accelerator {
      count = # value needed
      gpu_driver_installation_config {
        gpu_driver_version = # value needed
      }
      gpu_partition_size = # value needed
      gpu_sharing_config {
        gpu_sharing_strategy       = # value needed
        max_shared_clients_per_gpu = # value needed
      }
      type = # value needed
    }
  }
  node_pool {
    node_config {
      guest_accelerator {
        count = # value needed
        gpu_driver_installation_config {
          gpu_driver_version = # value needed
        }
        gpu_partition_size = # value needed
        gpu_sharing_config {
          gpu_sharing_strategy       = # value needed
          max_shared_clients_per_gpu = # value needed
        }
        type = # value needed
      }
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 230
Passed tests: 217
Skipped tests: 11
Affected tests: 2

Click here to see the affected service packages

• container

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccContainerNodePool_EmptyGuestAccelerator
• TestAccContainerNodePool_withGPU

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccContainerNodePool_withGPU [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🔴 Tests failed during RECORDING mode:
TestAccContainerNodePool_EmptyGuestAccelerator [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[NickElliot]

removing computed status from the entire block is definitely a breaking change as it no longer is providing output, is it possible to keep guest_accelerator as O+C?