Skip to content

feat: add support for managedPrivateNetwork in AwsS3Data storage transfer jobs #13655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

scottclay
Copy link

@scottclay scottclay commented Apr 12, 2025

storagetransfer: added `private_network` field to `google_storage_transfer_job` resource

Adds support for managedPrivateNetwork field from the API that allows transfers from AWS to GCP using the google private network.

Copy link

google-cla bot commented Apr 12, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions github-actions bot requested a review from ScottSuarez April 12, 2025 12:43
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: see go/terraform-auto-test-runs to set up automatic test runs.

@ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Apr 12, 2025
@scottclay
Copy link
Author

Duplicate of #13379 it seems

It's not clear to me how we should test this.

I can't see any of the existing AWS stuff tested in here but maybe I'm missing something?

I've tested it by building the provider locally and spinning up a STS job between AWS and GCP accounts/projects we own.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-approval Pull requests that need reviewer's approval to run presubmit tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants