Skip to content

Clean up buckets on e2e failure #3190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

gargnitingoogle
Copy link
Collaborator

@gargnitingoogle gargnitingoogle commented Apr 11, 2025

Description

It addresses two problems.

  1. Deletion of buckets created by E2E run script. The code is there in place, but it doesn't fully work in the following ways
    • It deletes objects but not the bucket itself, at least not if the test run fails, as I have many times gone back and deleted buckets manually afterwards.
  2. The deletion code doesn't get called if the script terminates early because of some test or environment issue causing a crash.

It also logs the bucket deletions if and when they are deleted.

Link to the issue in case of a bug fix.

b/409363794

Testing details

  1. Manual - NA
  2. Unit tests - NA
  3. Integration tests - NA

Any backward incompatible change? If so, please explain.

@kislaykishore kislaykishore requested review from a team and Tulsishah and removed request for a team April 11, 2025 13:59
@gargnitingoogle gargnitingoogle marked this pull request as ready for review April 11, 2025 14:16
@gargnitingoogle gargnitingoogle requested a review from a team as a code owner April 11, 2025 14:16
@gargnitingoogle gargnitingoogle added the execute-integration-tests-on-zb To run E2E tests on zonal bucket. label Apr 11, 2025
Copy link

codecov bot commented Apr 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.30%. Comparing base (1937ff7) to head (cb5ea5c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3190      +/-   ##
==========================================
+ Coverage   78.28%   78.30%   +0.01%     
==========================================
  Files         125      125              
  Lines       17305    17305              
==========================================
+ Hits        13547    13550       +3     
+ Misses       3302     3300       -2     
+ Partials      456      455       -1     
Flag Coverage Δ
unittests 78.30% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gargnitingoogle gargnitingoogle marked this pull request as draft April 11, 2025 14:38
@gargnitingoogle gargnitingoogle marked this pull request as ready for review April 11, 2025 14:48
@gargnitingoogle gargnitingoogle marked this pull request as draft April 14, 2025 05:17
@gargnitingoogle gargnitingoogle marked this pull request as ready for review April 15, 2025 18:42
@gargnitingoogle gargnitingoogle force-pushed the gargnitin/fix-zb-e2e/clean-up-buckets-on-e2e-failure/v1 branch from d9b2428 to 7bba624 Compare April 18, 2025 09:10
@gargnitingoogle gargnitingoogle force-pushed the gargnitin/fix-zb-e2e/clean-up-buckets-on-e2e-failure/v1 branch from b8cdc88 to 9031716 Compare April 18, 2025 09:44
@gargnitingoogle gargnitingoogle merged commit 0d723ff into master Apr 18, 2025
11 of 12 checks passed
@gargnitingoogle gargnitingoogle deleted the gargnitin/fix-zb-e2e/clean-up-buckets-on-e2e-failure/v1 branch April 18, 2025 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
execute-integration-tests-on-zb To run E2E tests on zonal bucket.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants