-
Notifications
You must be signed in to change notification settings - Fork 446
Clean up buckets on e2e failure #3190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
gargnitingoogle
merged 11 commits into
master
from
gargnitin/fix-zb-e2e/clean-up-buckets-on-e2e-failure/v1
Apr 18, 2025
Merged
Clean up buckets on e2e failure #3190
gargnitingoogle
merged 11 commits into
master
from
gargnitin/fix-zb-e2e/clean-up-buckets-on-e2e-failure/v1
Apr 18, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3190 +/- ##
==========================================
+ Coverage 78.28% 78.30% +0.01%
==========================================
Files 125 125
Lines 17305 17305
==========================================
+ Hits 13547 13550 +3
+ Misses 3302 3300 -2
+ Partials 456 455 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Tulsishah
reviewed
Apr 17, 2025
Tulsishah
reviewed
Apr 17, 2025
Tulsishah
reviewed
Apr 17, 2025
Tulsishah
reviewed
Apr 17, 2025
d9b2428
to
7bba624
Compare
b8cdc88
to
9031716
Compare
Tulsishah
approved these changes
Apr 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It addresses two problems.
It also logs the bucket deletions if and when they are deleted.
Link to the issue in case of a bug fix.
b/409363794
Testing details
Any backward incompatible change? If so, please explain.