-
Notifications
You must be signed in to change notification settings - Fork 2
feat: remove checkout and auth from setup-custard action #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glasnt
reviewed
Apr 14, 2025
glasnt
reviewed
Apr 14, 2025
briandorsey
approved these changes
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the checkout step outside of setup-custard. This gives more flexibility on what specific options to use on the code checkout.
This also embeds the JS setup code directly into the action step. This way, we don't need to checkout the tools repo for the JS source code. Eventually, all this setup code should be handled by the local runner.
Additionally, this enables creating checks both on workflow_run and pull_request (not fork) so that we can test end-to-end on PRs, while not breaking PRs from forks like renovate. I made more explicit check names to disambiguate between all the "duplicated checks".