Skip to content

feat: remove checkout and auth from setup-custard action #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Apr 17, 2025

Conversation

davidcavazos
Copy link
Collaborator

@davidcavazos davidcavazos commented Apr 8, 2025

Moves the checkout step outside of setup-custard. This gives more flexibility on what specific options to use on the code checkout.

This also embeds the JS setup code directly into the action step. This way, we don't need to checkout the tools repo for the JS source code. Eventually, all this setup code should be handled by the local runner.

The checkout on affected was not doing what we were expecting. It was checking out the caller repo, not the tools repo. So basically, the scripts file would have to exist in the language repo. Embedding the JS script is just a temporary workaround, once we have the local runner this will no longer be necessary and will go away

Additionally, this enables creating checks both on workflow_run and pull_request (not fork) so that we can test end-to-end on PRs, while not breaking PRs from forks like renovate. I made more explicit check names to disambiguate between all the "duplicated checks".

@davidcavazos davidcavazos requested a review from a team as a code owner April 8, 2025 17:37
@davidcavazos davidcavazos changed the title feat: remove checkout from setup-custard action feat: remove checkout and auth from setup-custard action Apr 8, 2025
@davidcavazos davidcavazos merged commit e1b1b61 into main Apr 17, 2025
18 checks passed
@davidcavazos davidcavazos deleted the setup-custard-sha branch April 17, 2025 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants