Skip to content

Fix removeListener signature #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix removeListener signature #38

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 15 additions & 9 deletions content/preamble.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,19 @@ interface DOMFileSystem extends FileSystem {}

// This is used to support addListener() where additional parameters are supported.
// The name is detected inside the developer.chrome.com repository and special actions are taken.
type CustomChromeEvent<H extends (...args: any) => void> =
Omit<chrome.events.Event<H>, 'addListener'> & {
type CustomChromeEvent<H extends (...args: any) => void> = Omit<
chrome.events.Event<H>,
"addListener" | "removeListener"
> & {
// nb. This just copies the description from `chrome.events.Event.addListener`.
/**
* Registers an event listener _callback_ to an event.
*/
readonly addListener: H;

// nb. This just copies the description from `chrome.events.Event.addListener`.
/**
* Registers an event listener _callback_ to an event.
*/
readonly addListener: H;

};
// This just copies the description from `chrome.events.Event.removeListener`.
/**
* Deregisters an event listener _callback_ from an event.
*/
readonly removeListener: H;
};