Revamp mobile navigation #3282
Open
Revamp mobile navigation #3282
+302
−191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 15e0adc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
nolannbiron
force-pushed
the
nolann/revamp-mobile-navigation
branch
from
0f4a839 to
af27aba
Compare
|
Summary of the deployments: Version 1
Version 2
Test content |
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
nolannbiron
force-pushed
the
nolann/revamp-mobile-navigation
branch
from
af27aba to
de795ca
Compare
nolannbiron
force-pushed
the
nolann/revamp-mobile-navigation
branch
2 times, most recently
from
d66bc22 to
1e5218e
Compare
nolannbiron
force-pushed
the
nolann/revamp-mobile-navigation
branch
from
1e5218e to
191dd67
Compare
nolannbiron
force-pushed
the
nolann/revamp-mobile-navigation
branch
from
d8e4f8a to
ab4af82
Compare
gregberge
approved these changes
Jun 16, 2025
Comment on lines
+11
to
+23
| // biome-ignore lint/correctness/useExhaustiveDependencies: Close the navigation when navigating to a page | ||
| useEffect(() => { | ||
| setOpen(false); | ||
| }, [pathname]); | ||
|
|
||
| useEffect(() => { | ||
| // If the menu is open, we add a class to the body to prevent scrolling | ||
| if (open) { | ||
| document.body.style.overflow = 'hidden'; | ||
| } else { | ||
| document.body.style.overflow = 'auto'; | ||
| } | ||
| }, [open]); |
There was a problem hiding this comment.
It's a bit more complicated than that:
Can you use that insteand?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.