Introduce Java library Stream plugin #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for Java/Kotlin JVM library modules by introducing a new convention plugin. The changes refactor the existing Kotlin configuration logic to be reusable across Android and pure JVM projects.
- Introduces
JavaLibraryConventionPluginfor non-Android Java/Kotlin library projects - Refactors Kotlin compiler configuration into a shared
configureKotlin()function - Extracts Java configuration into a reusable
configureJava()function
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| plugin/src/main/kotlin/io/getstream/android/StreamConventionPlugins.kt | Adds JavaLibraryConventionPlugin class and refactors configuration functions to support both Android and pure JVM projects |
| plugin/build.gradle.kts | Registers the new javaLibrary convention plugin with Gradle plugin portal |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
plugin/src/main/kotlin/io/getstream/android/StreamConventionPlugins.kt
Outdated
Show resolved
Hide resolved
gpunto
force-pushed
the
java-library
branch
2 times, most recently
from
3a190b8 to
b8f8875
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
plugin/src/main/kotlin/io/getstream/android/BaseConfiguration.kt
Outdated
Show resolved
Hide resolved
aleksandar-apostolov
approved these changes
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We also need a plugin for
java-librarymodules as we use those in some cases (e.g. in Chat).