Skip to content

Conversation

bviibvii
Copy link

直接把CryptoJS塞进去了,让扩展可以调用SHA家族的哈希算法和AES等对称加密算法

@kukemc
Copy link
Contributor

kukemc commented Feb 12, 2025

让你提交扩展没让你直接删库啊😂

Copy link
Contributor

@skydog221 skydog221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

没让你删库啊,真当HCN不做code review是吧
main.js不是拓展文件,你的拓展文件应该放在extension/${USERNAME}/${extensionName_en}里

@fath11
Copy link
Contributor

fath11 commented Feb 12, 2025

I do not recommend this PR to be merged. The author has to make a new PR that doesn't delete the whole library.

@skydog221
Copy link
Contributor

I do not recommend this PR to be merged. The author has to make a new PR that doesn't delete the whole library.

I also have the same suggestion, but for more than one reason. The author says that this expanded feature uses SHA and AES, which is not necessary in actual scratch programming, let alone the related "encryption" functions already available in the Aroks series extensions. I believe that this extension should not be merged into Github but should be available as a custom extension option in the "extensions experimental plaza".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants