Simplify representation of recursors in saw-core terms #2429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a step toward the complete removal of `RecursorApp` (#2358). The `RecursorApp` constructor still exists, and contains the list of index arguments to the recursor.
It was wrongly returning a lambda instead of a Pi type for the type of a recursor applied to indices. Now it correctly matches the type returned by scTypeCheck.
|
We have a couple of remaining test failures in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft PR that, when complete, will simplify the saw-core term representation by:
RecursorAppspecial application form in favor ofAppRecursorTypespecial form in favor of ordinaryPitypesRecursorterm constructor in favor ofConstantCompiledRecursorrecord in favor of fields stored in the datatype declaration in the global environment.This is a follow-up to PR #2422, intended to address #2358.