과제 1-1 hongjm0912 과제제출 #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snowykte0426
approved these changes
Jul 15, 2025
Comment on lines
+37
to
+49
| @PatchMapping("/{idx}") | ||
| public ResponseEntity<String> sujeong( | ||
| @PathVariable Long idx, | ||
| @RequestBody ArticleDTO dto) { | ||
| articleService.sujeong(idx, dto); | ||
| return ResponseEntity.ok("게시글이 수정되었습니다."); | ||
| } | ||
|
|
||
| @DeleteMapping("/{idx}") | ||
| public ResponseEntity<String> deleteByTitle(@PathVariable Long idx) { | ||
| articleService.sakjeByTitle(idx); | ||
| return ResponseEntity.noContent().build(); | ||
| } |
Comment on lines
+11
to
+15
| @ExceptionHandler(IllegalArgumentException.class) | ||
| public ResponseEntity<String> handleNotFound(IllegalArgumentException ex) { | ||
| return ResponseEntity.status(HttpStatus.NOT_FOUND).body(ex.getMessage()); | ||
| } | ||
| } |
There was a problem hiding this comment.
이렇게 핸들링하면 모든 IllegalArgumentException을 핸들링하게 되서 예외 클래스를 따로 생성하는 등의 방식으로 하여 세부화하여 핸들링 해주시면 좋겠습니다!
Comment on lines
+63
to
+64
| post.setTitle(dto.getTitle()); | ||
| post.setContent(dto.getContent()); |
There was a problem hiding this comment.
Setter(설정자) 사용은 지양하는게 좋습니다! Entity에서의 사용은 더더욱 지양해야하고요.
설정자의 사용은 개발자로 하여금 데이터를 빠르고 쉽게 수정가능 하도록 해주지만 다른 개발자로서 해당 행동이 왜 필요하고 최종적으로 어떤 목적으로 수정되는지 한번에 알기 어렵게 하고 외부에서 Entity가 의도치 않게 변경될 수 있습니다
| public List<ArticleDTO> findList() { | ||
| List<ArticleEntity> posts = articleRepository.findAll(); | ||
| if (posts.isEmpty()) { | ||
| return Collections.emptyList(); // 데이터가 없으면 200 OK + 빈 리스트([]) 반환 |
There was a problem hiding this comment.
따로 Empty를 감지하고, Collections.emptyList()를 반환한 이유가 무엇인가요?
| ArticleEntity post = articleRepository.findById(idx) | ||
| .orElseThrow(() -> new IllegalArgumentException("존재하지 않는 게시글입니다.")); | ||
|
|
||
| return new ArticleDTO( |
There was a problem hiding this comment.
정말 필요한 수정 사항은 아니지만, Entity to DTO를 담당하는 코드를 함수로 분리하는것도 좋은방법일것 같습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
과제 마무우리