Skip to content

Conversation

@JamesFromIT
Copy link

@JamesFromIT JamesFromIT commented Oct 6, 2019

I thought in some areas of the app readability could be improved:

  • I added spaces between some words in the App bar as well as the Install, Profiles and Status tabs.
  • Replaced the ellipsis in the strings files with the ellipsis character which is supposed to improve narration with Android Talkback (https://stackoverflow.com/q/8536375/7487871). This was a suggestion Android Studio made.
  • Fixed a display issue where the debug button would become too small to fit the text content (as demonstrated in issue A Display Bug #41).
  • Added labels to form inputs to improve accessibility.
  • Fixed spelling mistake in English strings.

…ipsis character) and added spaces to the app bar, install, profiles and status tabs.
@JamesFromIT
Copy link
Author

Hi,
Just checking in, is my pull request okay? I haven't contributed to public Github repos before, so just want to be sure I've done it right.

@restena-sw
Copy link
Contributor

Hi!

The PR looks good to me, it seems like you've done it right.

I prefer to let the maintainer, GarethAyres, read through and accept the PR though.

@JamesFromIT
Copy link
Author

Hi @restena-sw,

Thanks for the reply. That's good to know. :)

@JamesFromIT JamesFromIT mentioned this pull request Aug 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants