Remove threaded pdf parsing #978
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:XS
nadolskit
approved these changes
Jun 20, 2025
There was a problem hiding this comment.
Pull Request Overview
Removes the use of asyncio.to_thread for PDF parsing due to PyMuPDF’s lack of thread-safety, switching to a direct call and updating the explanatory comment.
- Call to
asyncio.to_threadremoved forparse_pdf_to_pages - Comment updated to reference PyMuPDF thread-safety documentation
- PDF parsing now runs synchronously within
read_doc
jamesbraza
approved these changes
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing multi-threading from the pdf parsing, as pymypdf is not threadsafe per the documentation. When parsing many large files simultaneously, i.e. patents, pqa was throwing segmentation faults otherwise.