Skip to content

Fixed README typo from answer.k to answer.evidence_k #974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 16, 2025
Merged

Fixed README typo from answer.k to answer.evidence_k #974

merged 1 commit into from
Jun 16, 2025

Conversation

jamesbraza
Copy link
Collaborator

Looks like #344 had a typo.

Closes #958

@jamesbraza jamesbraza self-assigned this Jun 14, 2025
@Copilot Copilot AI review requested due to automatic review settings June 14, 2025 18:55
@jamesbraza jamesbraza added the bug Something isn't working label Jun 14, 2025
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jun 14, 2025
Copilot
Copilot AI reviewed Jun 14, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a typo in the README by updating the property name from settings.answer.k to settings.answer.evidence_k.

  • Corrected the property name in the settings configuration example in the README.

@dosubot dosubot bot added the documentation Improvements or additions to documentation label Jun 14, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 16, 2025
@jamesbraza jamesbraza merged commit 0407d0a into main Jun 16, 2025
5 of 7 checks passed
@jamesbraza jamesbraza deleted the fixing-readme-typo branch June 16, 2025 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@maykcaldas maykcaldas maykcaldas approved these changes

@nadolskit nadolskit nadolskit approved these changes

@whitead whitead Awaiting requested review from whitead

@mskarlin mskarlin Awaiting requested review from mskarlin

Assignees

@jamesbraza jamesbraza

Labels
bug Something isn't working documentation Improvements or additions to documentation lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

What parameter determines top k sources?
3 participants
@jamesbraza @maykcaldas @nadolskit