Skip to content

Disable V-Sync option on web builds #5062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Disable V-Sync option on web builds #5062

wants to merge 1 commit into from

Conversation

NotHyper-474
Copy link
Contributor

@NotHyper-474 NotHyper-474 commented May 11, 2025 •
edited
Loading

Linked Issues

...

Description

Disables the option on web builds since it's pretty much non functional.

Screenshots/Videos

image

@github-actions github-actions bot added pr: haxe PR modifies game code. status: pending triage Awaiting review. size: medium A medium pull request with 100 or fewer changes. labels May 11, 2025
charlesisfeline
charlesisfeline suggested changes May 11, 2025
View reviewed changes
Copy link

@charlesisfeline charlesisfeline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keep the conditional for the fps option too btw

@NotHyper-474
Copy link
Contributor Author

keep the conditional for the fps option too btw

The FPS option was not affected.

@charlesisfeline
Copy link

keep the conditional for the fps option too btw

The FPS option was not affected.

oh right i didnt check twice aight

@AbnormalPoof AbnormalPoof added the topic: platform specific Specific to only one or several of the game's supported targets. label May 11, 2025
@Hundrec Hundrec added the type: minor bug Involves a minor bug or issue. label May 12, 2025
@EliteMasterEric EliteMasterEric added size: small A small pull request with 10 or fewer changes. and removed size: medium A medium pull request with 100 or fewer changes. size: small A small pull request with 10 or fewer changes. labels May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charlesisfeline charlesisfeline Awaiting requested review from charlesisfeline

Assignees
No one assigned
Labels
pr: haxe PR modifies game code. size: small A small pull request with 10 or fewer changes. status: pending triage Awaiting review. topic: platform specific Specific to only one or several of the game's supported targets. type: minor bug Involves a minor bug or issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@NotHyper-474 @charlesisfeline @EliteMasterEric @AbnormalPoof @Hundrec