Skip to content

Bug Report: Forced Animations not overwriting note animations #3491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
2 tasks done
Greeny3483 opened this issue Sep 30, 2024 · 4 comments
Open
2 tasks done

Bug Report: Forced Animations not overwriting note animations #3491

Greeny3483 opened this issue Sep 30, 2024 · 4 comments
Labels
status: pending triage Awaiting review. topic: art and animation Related to visual errors in the game. type: minor bug Involves a minor bug or issue.

Comments

@Greeny3483
Copy link

Issue Checklist

  • I have properly named the issue
  • I have checked the issues/discussions pages to see if the issue has been previously reported

What platform are you using?

Itch.io (Downloadable Build) - Windows

If you are playing on a browser, which one are you using?

None

Version

0.5.1

Context (Provide images, videos, etc.)

In previous versions before the 0.5.0: Pico Update, the "Play Animation" event would overwrite the note animations if "Force" was checked, this seems to no longer be the case.

Whether this is a bug or intentional, I request for this to be fixed, as it creates problems with modding.

Steps to reproduce (or crash logs, errors, etc.)

  1. Open the Chart Editor
  2. Place a note
  3. Place a "Play Animation" event on the same line as the note (and configure it)
  4. Test and see results
@Greeny3483 Greeny3483 added status: pending triage Awaiting review. type: minor bug Involves a minor bug or issue. labels Sep 30, 2024
@Hundrec Hundrec added the topic: chart editor Related to the operation of the Chart Editor. label Mar 9, 2025
@Hundrec Hundrec marked this as a duplicate of #4501 Apr 2, 2025
@Hundrec
Copy link
Collaborator

Hundrec commented Apr 2, 2025

Confirmed to be still present in 0.6.2
Darn!

@Hundrec Hundrec added topic: art and animation Related to visual errors in the game. and removed topic: chart editor Related to the operation of the Chart Editor. labels May 16, 2025
@Lasercar
Copy link
Contributor

Does the event in the json get set to force the animation (maybe it's not saving or being set properly)?

@Hundrec
Copy link
Collaborator

Hundrec commented May 18, 2025

Events do retain their force property, they just don't work properly when very close to a note

@Lasercar
Copy link
Contributor

Lasercar commented May 18, 2025 •
edited
Loading

I think the problem is this:

Funkin/source/funkin/play/character/BaseCharacter.hx

Lines 149 to 155 in d127b82

public function new(id:String, renderType:CharacterRenderType)
{
super(CharacterDataParser.DEFAULT_DANCEEVERY);
this.characterId = id;
ignoreExclusionPref = ["sing"];

ignoreExclusionPref has been set so that any animation starting with sing can still play even when an animation is forced.

Funkin/source/funkin/play/stage/Bopper.hx

Lines 264 to 285 in d127b82

public function playAnimation(name:String, restart:Bool = false, ignoreOther:Bool = false, reversed:Bool = false):Void
{
if ((!canPlayOtherAnims))
{
var id = name;
if (getCurrentAnimation() == id && restart) {}
else if (ignoreExclusionPref != null && ignoreExclusionPref.length > 0)
{
var detected:Bool = false;
for (entry in ignoreExclusionPref)
{
if (StringTools.startsWith(id, entry))
{
detected = true;
break;
}
}
if (!detected) return;
}
else
return;
}

Perhaps it was added to test the new functionality and it was never removed.

Easiest way to fix this is just to null the ignoreExclusionPref after super in the new function for a character.

This was referenced May 18, 2025
Closed
Closed
@AbnormalPoof AbnormalPoof mentioned this issue May 21, 2025
Draft
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: pending triage Awaiting review. topic: art and animation Related to visual errors in the game. type: minor bug Involves a minor bug or issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[BUGFIX] Sing animations not ignored when animation is forced Lasercar/Funkin
3 participants
@Lasercar @Hundrec @Greeny3483