fixed flickering of priest 2 (player 2) when escorting with scavenger

[yousefsassy]

this fixes issue : #2698

issue:

When using the Scavenger’s Escort ability on both Player 1’s (Red) and Player 2’s (Blue) Priests, player 1(red) was escorted successfully but when we try to escort the second player (priest blue) via the same scavenger it filickers between grey and blue which is not the correct behavior it should stay blue.
here is before :

and here is after :

Screen.Recording.2025-05-13.at.10.02.55.PM.mov

Root Cause:

The flickering was caused by G.grid.previewCreature(trgPos, targetData, trg.player, true) being called after applying the manual displayVisualState() and overlayVisualState(). The previewCreature method was continuously overriding the target’s hex visuals with a default semi-transparent or neutral (grey) model.

Fix:

We commented out the call to:

G.grid.previewCreature(trgPos, targetData, trg.player, true);

in the select() function of the Scavenger’s Escort logic. This prevents the preview function from interfering with the manually applied team-colored visual states (playerX), effectively eliminating the flicker.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
ancientbeast	✅ Ready (Inspect)	Visit Preview	May 13, 2025 9:36pm

[DreadKnight]

@yousefsassy I've tested it and I find it rather hacky, as it's one step forward, one step back in the sense the PR should actually fix the Dark Priest preview during Escort Service ability, not have that disabled...
Will mark as draft for now and wait for a proper fix 🐻

[DreadKnight]

@yousefsassy Hey! Any progress with this one? 🐻