Skip to content

Landscape orientation for android fix #2714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

Landscape orientation for android fix #2714

wants to merge 7 commits into from

Conversation

pranshugupta01
Copy link
Contributor

@pranshugupta01 pranshugupta01 commented Apr 26, 2025 •
edited
Loading

This fixes issue #2711

@pranshugupta01
Refactor fullscreen handling: Introduce methods for checking fullscre…
4078d3a 
…en state, requesting and exiting fullscreen, and locking screen orientation. Update toggle logic to utilize new methods and improve compatibility across browsers.
@pranshugupta01
Update viewport meta tag for improved responsiveness and user experie…
5634f5f 
…nce on mobile devices
@vercel Vercel
Copy link

vercel bot commented Apr 26, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
ancientbeast ✅ Ready (Inspect) Visit Preview Apr 26, 2025 8:38pm

@pranshugupta01 pranshugupta01 marked this pull request as ready for review April 26, 2025 20:05
@pranshugupta01 pranshugupta01 mentioned this pull request Apr 26, 2025
Open
@pranshugupta01
Copy link
Contributor Author

Hey @DreadKnight , this is fix for android landscape orientation , on ios i am facing issue related to fullscreen api

@DreadKnight
Copy link
Member

@pranshugupta01 Um, as I was saying, that issue is not about fullscreen mode...

@pranshugupta01
Copy link
Contributor Author

@pranshugupta01 Um, as I was saying, that issue is not about fullscreen mode...

No in this i have implemented landscape mode , am i missing something?? @DreadKnight

@DreadKnight
Copy link
Member

@pranshugupta01 Tested it on Android (Samsung S21) and it doesn't work.
Plus most code there is clearly related to fullscreen mode 🐻

@pranshugupta01
Copy link
Contributor Author

@pranshugupta01 Tested it on Android (Samsung S21) and it doesn't work. Plus most code there is clearly related to fullscreen mode 🐻

sorry i forgot to take the latest pull , it is working fine for me now (tested in google pixel 7) , after clicking on fullscreen button , the games orients to landscape

@pranshugupta01
Copy link
Contributor Author

@DreadKnight sorry but are you talking about the behaviour like the game itself starts in landscape mode?

@DreadKnight
Copy link
Member

@DreadKnight sorry but are you talking about the behaviour like the game itself starts in landscape mode?

Bingo! In fullscreen it's landscape mode locked already anyway.

@DreadKnight DreadKnight mentioned this pull request Apr 27, 2025
Open
@DreadKnight DreadKnight marked this pull request as draft April 29, 2025 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pranshugupta01 @DreadKnight