You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR addresses issue #2688, where using Scavenger's Escort Service -> skipTurn left the previewCreature sprites for both Scavenger and the target behind. It can be noted that Scavenger's ghost disappeared when its player generated a new one by hovering over a new move tile during their turn, but the enemy's ghost would not.
Changes:
Added minimal logic in skipTurn() of Game.ts to fade out and replace both materialize_overlay and secondary_overlay with a null value.
Escort.mov
Effect:
Both ghosts disappear upon skipTurn. Shouldn't be any adverse effects, as the game simply generates new materialize_overlay/secondary_overlay whenever previewCreature is called and the value is not found.
@nibrandn I've tested this and it works, but I think the best approach is to change the mechanics a bit if possibly (hopefully simplifying stuff while keeping everything more consistent), so that the preview vanishes once the cursor is not over one of the valid targeting location, like in case for movement and movement related abilities (such as Uncle Fungus' Frogger Jump). Let me know what you think 🐻
@DreadKnight That makes sense to me, I just assumed the preview lingering regardless of whether the cursor was hovering or not was a feature for user accessibility. Maybe we could implement it as just another turn for movement, limited to the x and y directions?
@DreadKnight That makes sense to me, I just assumed the preview lingering regardless of whether the cursor was hovering or not was a feature for user accessibility. Maybe we could implement it as just another turn for movement, limited to the x and y directions?
@nibrandn That was my thought, no lingering, ideally code being reused.
@DreadKnight Do you want me to take a look at that? I'm currently starting my finals season for school, so I'm not sure when I'll have time to dive into it.
@DreadKnight Do you want me to take a look at that? I'm currently starting my finals season for school, so I'm not sure when I'll have time to dive into it.
Alright, good luck with the finals!
I guess you can poke at it after 🐻
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #2688, where using Scavenger's Escort Service -> skipTurn left the previewCreature sprites for both Scavenger and the target behind. It can be noted that Scavenger's ghost disappeared when its player generated a new one by hovering over a new move tile during their turn, but the enemy's ghost would not.
Changes:
Added minimal logic in skipTurn() of Game.ts to fade out and replace both materialize_overlay and secondary_overlay with a null value.
Escort.mov
Effect:
Both ghosts disappear upon skipTurn. Shouldn't be any adverse effects, as the game simply generates new materialize_overlay/secondary_overlay whenever previewCreature is called and the value is not found.
Tested on Google Chrome
No need for tokens
#2688