You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shows a preview for non-melee abilities that disappears after a delay when clicking an ability when it is unavailable. Changes the way handling abilities work with a new isPreview condition for query. Possible phase out the strict way of disabling abilities after 1 use and simply treats them as lacking suitable targets.
Locally, it passed the Jest tests and it seems to run.
@Kevin4335 I bet, but you know how development goes when it comes to different machines... you could also poke at a browser based IDE, even Github provides one. Usually there's a small thing that breaks big changes on various set-ups.
@Kevin4335 Really looking forward to test out this patch! 🤞🏻
No pressure, but note that if it takes too long, it might have some conflicts to resolve when trying to merge this into master 🐻
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DreadKnight
changed the title
Shows a preview for non-melee abilities that disappears after a delay when clicking an ability when it is unavailable. Changes the way handling abilities work with a new isPreview condition for query. Possible phase out the strict way of disabling abilities after 1 use and simply treats them as lacking suitable targets.
This fixes issue #970
(I do not have a ERC20 wallet)