Skip to content

Added "Share Replay" Button, Icon, and Download Feature #2676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yousefsassy
Copy link
Contributor

Description

This fixes issue #1779.

This PR addresses Issue #1779 by adding a "Share Replay" button to the scoreboard screen. The changes include:

share.svg icon added to assets/interface/ for the button.

The ability for users to download match replay logs in JSON format.

The button’s size and alignment have been matched with the "Flee Match" button for consistency.

Changes made:

index.ejs: Implemented the "Share Replay" button and wired the functionality for exporting replay logs.

assets/interface: Added share.svg icon used for the button.

styles.less: Ensured the "Share Replay" button has the same size and positioning as the "Flee Match" button.

interface.js: Added logic to enable downloading of replay logs in JSON format when the "Share Replay" button is clicked.

Wallet address:
0x0000000000000000000000000000000000000000

Copy link

vercel bot commented Mar 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
ancientbeast ✅ Ready (Inspect) Visit Preview Mar 28, 2025 5:06pm

@DreadKnight
Copy link
Member

@yousefsassy As indicated in the "contribution" guide, usually try not to poke at issues that have the "brainstorm" tag and/or are in a too far away milestone. This is pretty good, but will need a bit more work, will tweak original specs, contribute a bit to the PR myself and request a few more tweaks from you as well pretty soon 🐻👍🏻
Also, please update wallet address with proper one or don't include a bad one :D

@DreadKnight DreadKnight marked this pull request as draft March 29, 2025 10:54
@DreadKnight
Copy link
Member

@yousefsassy

Heya! Looked more at this. Here's a list of glitches that would need fixing and things that could be improved:

  • new icon that reflects better the action - https://game-icons.net/1x1/delapouite/save-arrow.html
  • icon style consistency: transparent background and 4px black outline (doable from game-icons.net editor itself)
  • the icon shouldn't be moved to the left side a bit when the "restart match" is being hovered and showing a tooltip
  • the icon shouldn't zoom in a bit on hover in order to keep consistency
  • should have a tooltip and showcase hotkey in it (Ctrl+S) like the "restart match"

@yousefsassy
Copy link
Contributor Author

@DreadKnight got it ! you told me that this issue has a brainstorm tag so its not recommended for me to poke at it since you replied to me about this issue, means that it doesnt belong to the brainstorm section anymore and can work on it ?

@DreadKnight
Copy link
Member

@DreadKnight got it ! you told me that this issue has a brainstorm tag so its not recommended for me to poke at it since you replied to me about this issue, means that it doesnt belong to the brainstorm section anymore and can work on it ?

@yousefsassy Yeah, go for that list of to-do's. Once everything is checked, I will get this merged in.

@DreadKnight
Copy link
Member

@yousefsassy Any progress with this one? It's starting to get conflicts...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants