Fix Scavenger's Escort Service to allow movement of one hex

[aybanda]

This fixes issue #2616

Description of Changes

This pull request addresses the issue with the "Scavenger's Escort Service" ability by allowing it to function correctly even when moving a target unit by only one hex. The following changes have been made:

• Updated the require() function to allow the ability to be activated with one usable hex.
• Refined the filtering logic to ensure the ability can still be used effectively.
• Adjusted the movement logic to ensure at least one movement point is deducted.

Wallet Address

My wallet address is 0xfBA90c8Fd61AcD3aa1e086628dc402Aa34334aDc

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
ancientbeast	✅ Ready (Inspect)	Visit Preview	Nov 27, 2024 6:52am

[DreadKnight]

@aybanda Heya! Thanks for the PR. I've increased XTR bounty for this. I've tested this and works like in master, no change:

[DreadKnight]

@aybanda Hey! Happy new year! 🥳 Any progress with this? 🐻

[emna9]

Hi @aybanda ,
I’ve reviewed your changes, and I appreciate the adjustments you made,but it looks like the issue may still stem from the way the hovered position and shift calculations are handled. Specifically:

The shift logic for calculating the movement between tiles might be missing a finer check when the movement distance is just 1 hex.

There could be issues with how the target and scavenger positions are updated when moving a single tile.

Suggestions:

Ensure that the shift calculation accounts for a movement of just 1 hex, especially in cases where the block needs to move by a small amount but still respects the creature's space and the available hexes.

Double-check that the hovered position and hex checks align properly for both the target and the scavenger creatures.

It might be useful to also review the block-start and end conditions more carefully to ensure no tiles are skipped over when the block is moved by just 1 hex.

Let me know if you need further details.
Best,
Emna.

[DreadKnight]

@emna9 Thanks for helping out with a proper review and suggestions 🫶🏻
In this scenario most likely stuff will be ignored and someone else will eventually tackle the issue (as you did, will review yours soon and close this after if it does the job).