[pull] master from tfutils:master

.github/dependabot.yml

@@ -0,0 +1,7 @@
+---
+version: 2
+updates:
+  - package-ecosystem: "github-actions"
+    directory: "/"
+    schedule:
+      interval: "monthly"

.github/workflows/test.yml

@@ -21,7 +21,7 @@ jobs:
           - 'macos-latest'
           - 'ubuntu-latest'
     steps:
-      - uses: 'actions/checkout@v2'
+      - uses: 'actions/checkout@v4'
         with:
           fetch-depth: 1
       - name: 'Install Dependencies'
@@ -30,21 +30,21 @@ jobs:
         run: './test/run.sh'
         shell: 'bash'
 
-      - uses: 'docker/setup-buildx-action@v2'
+      - uses: 'docker/setup-buildx-action@v3'
         if: contains(matrix.os, 'ubuntu')
         with:
           install: true
-      - uses: 'docker/build-push-action@v3'
+      - uses: 'docker/build-push-action@v6'
         if: contains(matrix.os, 'ubuntu')
         with:
           context: .
           load: true
-          tags: "tfenv-terraform:${{ github.head_ref }}"
+          tags: "tfenv-terraform:${{ github.sha }}"
       - name: 'Check Dockerfile'
         if: contains(matrix.os, 'ubuntu')
         run: |
           expect=1.2.3;
-          got="$(docker run -e "TFENV_TERRAFORM_VERSION=${expect}" "tfenv-terraform:${{ github.head_ref }}" version)";
+          got="$(docker run -e "TFENV_TERRAFORM_VERSION=${expect}" "tfenv-terraform:${{ github.sha }}" version)";
           echo "${got}" | tee /dev/stderr | grep -e 'Terraform v1.2.3'
 
   # When we push to master, test everything in order to guarantee releases
@@ -54,13 +54,14 @@ jobs:
     strategy:
       matrix:
         os:
-          - 'macos-11'
-          - 'macos-10.15'
-          - 'ubuntu-20.04'
-          - 'ubuntu-18.04'
-          - 'windows-2019'
+          - 'ubuntu-24.04'
+          - 'ubuntu-22.04'
+          - 'macos-14'
+          - 'macos-13'
+          - 'windows-2025'
+          - 'windows-2022'
     steps:
-      - uses: 'actions/checkout@v2'
+      - uses: 'actions/checkout@v4'
         with:
           fetch-depth: 1
       - name: 'Install Dependencies'
@@ -69,11 +70,11 @@ jobs:
         run: './test/run.sh'
         shell: 'bash'
 
-      - uses: 'docker/setup-buildx-action@v2'
+      - uses: 'docker/setup-buildx-action@v3'
         if: contains(matrix.os, 'ubuntu')
         with:
           install: true
-      - uses: 'docker/build-push-action@v3'
+      - uses: 'docker/build-push-action@v6'
         if: contains(matrix.os, 'ubuntu')
         with:
           context: .

README.md

@@ -1,4 +1,4 @@
-![CI](https://github.com/tfutils/tfenv/workflows/CI/badge.svg)
+[![CI Test](https://github.com/tfutils/tfenv/actions/workflows/test.yml/badge.svg)](https://github.com/tfutils/tfenv/actions/workflows/test.yml)
 
 # tfenv
 
@@ -23,13 +23,13 @@ Currently tfenv supports the following OSes
 Install via Homebrew
 
 ```console
-$ brew install tfenv
+brew install tfenv
 ```
 
 Install via Arch User Repository (AUR)
 
 ```console
-$ yay --sync tfenv
+yay --sync tfenv
 ```
 
 Install via puppet
@@ -45,34 +45,45 @@ include ::tfenv
 1. Check out tfenv into any path (here is `${HOME}/.tfenv`)
 
 ```console
-$ git clone --depth=1 https://github.com/tfutils/tfenv.git ~/.tfenv
+git clone --depth=1 https://github.com/tfutils/tfenv.git ~/.tfenv
 ```
 
 2. Add `~/.tfenv/bin` to your `$PATH` any way you like
 
+bash:
 ```console
-$ echo 'export PATH="$HOME/.tfenv/bin:$PATH"' >> ~/.bash_profile
+echo 'export PATH="$HOME/.tfenv/bin:$PATH"' >> ~/.bash_profile
 ```
 
-  For WSL users
+zsh:
+```console
+echo 'export PATH="$HOME/.tfenv/bin:$PATH"' >> ~/.zprofile
+```
+
+fish:
+```console
+echo 'set -x PATH $HOME/.tfenv/bin $PATH' >> ~/.config/fish/config.fish
+```
+
+For WSL users:
 ```bash
-$ echo 'export PATH=$PATH:$HOME/.tfenv/bin' >> ~/.bashrc
+echo 'export PATH=$PATH:$HOME/.tfenv/bin' >> ~/.bashrc
 ```
 
   OR you can make symlinks for `tfenv/bin/*` scripts into a path that is already added to your `$PATH` (e.g. `/usr/local/bin`) `OSX/Linux Only!`
 
 ```console
-$ ln -s ~/.tfenv/bin/* /usr/local/bin
+ln -s ~/.tfenv/bin/* /usr/local/bin
 ```
 
   On Ubuntu/Debian touching `/usr/local/bin` might require sudo access, but you can create `${HOME}/bin` or `${HOME}/.local/bin` and on next login it will get added to the session `$PATH`
   or by running `. ${HOME}/.profile` it will get added to the current shell session's `$PATH`.
 
 ```console
-$ mkdir -p ~/.local/bin/
-$ . ~/.profile
-$ ln -s ~/.tfenv/bin/* ~/.local/bin
-$ which tfenv
+mkdir -p ~/.local/bin/
+. ~/.profile
+ln -s ~/.tfenv/bin/* ~/.local/bin
+which tfenv
 ```
 
 ## Usage
@@ -91,7 +102,7 @@ If a parameter is passed, available options:
 - `latest-allowed` is a syntax to scan your Terraform files to detect which version is maximally allowed.
 - `min-required` is a syntax to scan your Terraform files to detect which version is minimally required.
 
-See [required_version](https://www.terraform.io/docs/configuration/terraform.html) docs. Also [see min-required & latest-allowed](#min-required) section below.
+See [required_version](https://developer.hashicorp.com/terraform/language/settings) docs. Also [see min-required & latest-allowed](#min-required) section below.
 
 ```console
 $ tfenv install
@@ -110,8 +121,8 @@ You can opt-in to using GnuPG tools for PGP signature verification if keybase is
 Where `TFENV_INSTALL_DIR` is for example, `~/.tfenv` or `/usr/local/Cellar/tfenv/<version>`
 
 ```console
-$ echo 'trust-tfenv: yes' > ${TFENV_INSTALL_DIR}/use-gpgv
-$ tfenv install
+echo 'trust-tfenv: yes' > ${TFENV_INSTALL_DIR}/use-gpgv
+tfenv install
 ```
 
 The `trust-tfenv` directive means that verification uses a copy of the
@@ -157,7 +168,7 @@ Specify architecture. Architecture other than the default amd64 can be specified
 Note: Default changes to `arm64` for versions that have arm64 builds available when `$(uname -m)` matches `aarch64* | arm64*`
 
 ```console
-$ TFENV_ARCH=arm64 tfenv install 0.7.9
+TFENV_ARCH=arm64 tfenv install 0.7.9
 ```
 
 ##### `TFENV_AUTO_INSTALL`
@@ -167,11 +178,11 @@ String (Default: true)
 Should tfenv automatically install terraform if the version specified by defaults or a .terraform-version file is not currently installed.
 
 ```console
-$ TFENV_AUTO_INSTALL=false terraform plan
+TFENV_AUTO_INSTALL=false terraform plan
 ```
 
 ```console
-$ terraform use <version that is not yet installed>
+terraform use <version that is not yet installed>
 ```
 
 ##### `TFENV_CURL_OUTPUT`
@@ -202,7 +213,7 @@ String (Default: https://releases.hashicorp.com)
 To install from a remote other than the default
 
 ```console
-$ TFENV_REMOTE=https://example.jfrog.io/artifactory/hashicorp
+TFENV_REMOTE=https://example.jfrog.io/artifactory/hashicorp
 ```
 
 ##### `TFENV_REVERSE_REMOTE`
@@ -217,7 +228,7 @@ is instead providing a list that is oldes-first, set `TFENV_REVERSE_REMOTE=1` an
 functionality will be restored.
 
 ```console
-$ TFENV_REVERSE_REMOTE=1 tfenv list-remote
+TFENV_REVERSE_REMOTE=1 tfenv list-remote
 ```
 
 ##### `TFENV_CONFIG_DIR`
@@ -241,7 +252,7 @@ If not empty string, this variable overrides Terraform version, specified in [.t
 e.g.
 
 ```console
-$ TFENV_TERRAFORM_VERSION=latest:^0.11. terraform --version
+TFENV_TERRAFORM_VERSION=latest:^0.11. terraform --version
 ```
 
 ##### `TFENV_NETRC_PATH`
@@ -253,7 +264,7 @@ If not empty string, this variable specifies the credentials file used to access
 e.g.
 
 ```console
-$ TFENV_NETRC_PATH="$PWD/.netrc.tfenv"
+TFENV_NETRC_PATH="$PWD/.netrc.tfenv"
 ```
 
 #### Bashlog Logging Library
@@ -294,7 +305,7 @@ Each executable logs to its own file.
 e.g.
 
 ```console
-$ BASHLOG_FILE=1 tfenv use latest
+BASHLOG_FILE=1 tfenv use latest
 ```
 
 will log to `/tmp/tfenv-use.log`
@@ -316,7 +327,7 @@ This variable allows you to pass a string containing a command that will be exec
 e.g.
 
 ```console
-$ BASHLOG_I_PROMISE_TO_BE_CAREFUL_CUSTOM_EVAL_PREFIX='echo "${$$} "'
+BASHLOG_I_PROMISE_TO_BE_CAREFUL_CUSTOM_EVAL_PREFIX='echo "${$$} "'
 ```
 will prefix every log line with the calling process' PID.
 
@@ -332,7 +343,7 @@ Each executable logs to its own file.
 e.g.
 
 ```console
-$ BASHLOG_JSON=1 tfenv use latest
+BASHLOG_JSON=1 tfenv use latest
 ```
 
 will log in JSON format to `/tmp/tfenv-use.log.json`
@@ -356,10 +367,10 @@ To log to syslog using the `logger` binary, set this to 1.
 The basic functionality is thus:
 
 ```console
-$ local tag="${BASHLOG_SYSLOG_TAG:-$(basename "${0}")}";
-$ local facility="${BASHLOG_SYSLOG_FACILITY:-local0}";
-$ local pid="${$}";
-$ logger --id="${pid}" -t "${tag}" -p "${facility}.${severity}" "${syslog_line}"
+local tag="${BASHLOG_SYSLOG_TAG:-$(basename "${0}")}";
+local facility="${BASHLOG_SYSLOG_FACILITY:-local0}";
+local pid="${$}";
+logger --id="${pid}" -t "${tag}" -p "${facility}.${severity}" "${syslog_line}"
 ```
 
 ##### `BASHLOG_SYSLOG_FACILITY`
@@ -489,13 +500,13 @@ Terraform v0.7.3
 ## Upgrading
 
 ```console
-$ git --git-dir=~/.tfenv/.git pull
+git --git-dir=~/.tfenv/.git pull
 ```
 
 ## Uninstalling
 
 ```console
-$ rm -rf /some/path/to/tfenv
+rm -rf /some/path/to/tfenv
 ```
 
 ## LICENSE

lib/helpers.sh

@@ -118,10 +118,17 @@ export -f check_default_version;
 function cleanup() {
   log 'info' 'Performing cleanup';
   local pwd="$(pwd)";
-  log 'debug' "Deleting ${pwd}/version";
-  rm -rf ./version;
-  log 'debug' "Deleting ${pwd}/versions";
-  rm -rf ./versions;
+
+  # Safety check to ensure TFENV_CONFIG_DIR is set and not empty
+  if [ -z "${TFENV_CONFIG_DIR:-""}" ]; then
+    log 'error' 'TFENV_CONFIG_DIR is not set, cannot perform cleanup safely';
+    return 1;
+  fi;
+
+  log 'debug' "Deleting ${TFENV_CONFIG_DIR}/version";
+  rm -rf "${TFENV_CONFIG_DIR}/version";
+  log 'debug' "Deleting ${TFENV_CONFIG_DIR}/versions";
+  rm -rf "${TFENV_CONFIG_DIR}/versions";
   log 'debug' "Deleting ${pwd}/.terraform-version";
   rm -rf ./.terraform-version;
   log 'debug' "Deleting ${pwd}/latest_allowed.tf";

lib/tfenv-exec.sh

@@ -2,11 +2,39 @@
 
 set -uo pipefail;
 
+function realpath-relative-to() {
+  # A basic implementation of GNU `realpath --relative-to=$1 $2`
+  # that can also be used on macOS.
+
+  # http://stackoverflow.com/questions/1055671/how-can-i-get-the-behavior-of-gnus-readlink-f-on-a-mac
+  readlink_f() {
+    local target_file="${1}";
+    local file_name;
+
+    while [ "${target_file}" != "" ]; do
+      cd "$(dirname "$target_file")" || early_death "Failed to 'cd \$(${target_file%/*})'";
+      file_name="${target_file##*/}" || early_death "Failed to '\"${target_file##*/}\"'";
+      target_file="$(readlink "${file_name}")";
+    done;
+
+    echo "$(pwd -P)/${file_name}";
+  };
+
+  local relative_to="$(readlink_f "${1}")";
+  local path="$(readlink_f "${2}")";
+
+  echo "${path#"${relative_to}/"}";
+  return 0;
+}
+export -f realpath-relative-to;
+
 function tfenv-exec() {
   for _arg in ${@:1}; do
     if [[ "${_arg}" == -chdir=* ]]; then
-      log 'debug' "Found -chdir arg. Setting TFENV_DIR to: ${_arg#-chdir=}";
-      export TFENV_DIR="${PWD}/${_arg#-chdir=}";
+      chdir="${_arg#-chdir=}";
+      log 'debug' "Found -chdir arg: ${chdir}";
+      export TFENV_DIR="${PWD}/$(realpath-relative-to "${PWD}" "${chdir}")";
+      log 'debug' "Setting TFENV_DIR to: ${TFENV_DIR}";
     fi;
   done;
 

lib/tfenv-version-name.sh

@@ -10,7 +10,7 @@ function tfenv-version-name() {
       && log 'debug' "TFENV_VERSION_FILE retrieved from tfenv-version-file: ${TFENV_VERSION_FILE}" \
       || log 'error' 'Failed to retrieve TFENV_VERSION_FILE from tfenv-version-file';
 
-    TFENV_VERSION="$(cat "${TFENV_VERSION_FILE}" || true)" \
+    TFENV_VERSION="$(cat "${TFENV_VERSION_FILE}" || true | tr -d '\r')" \
       && log 'debug' "TFENV_VERSION specified in TFENV_VERSION_FILE: ${TFENV_VERSION}";
 
     TFENV_VERSION_SOURCE="${TFENV_VERSION_FILE}";

libexec/tfenv-install

@@ -89,10 +89,10 @@ case "$(uname -s)" in
   MINGW64*)
     kernel="windows";
     ;;
-  MSYSNT*)
+  MSYS*NT*)
     kernel="windows";
     ;;
-  CYGWINNT*)
+  CYGWIN*NT*)
     kernel="windows";
     ;;
   FreeBSD*)
@@ -124,7 +124,7 @@ case "$(uname -m)" in
       ;;
       "darwin")
         # No Apple Silicon builds before 1.0.2
-        if [[ "${version}" =~ 0\..+$ || "${version}" =~ 1\.0\.0|1$
+        if [[ "${version}" =~ ^0\.[0-9]+\.[0-9]+ || "${version}" =~ ^1\.0\.[0-1]$
         ]]; then
           TFENV_ARCH="${TFENV_ARCH:-amd64}";
         else

libexec/tfenv-min-required

@@ -68,7 +68,7 @@ terraform {
   required_version = ">= 0.0.0"
 }
 
-see https://www.terraform.io/docs/configuration/terraform.html for details';
+see https://developer.hashicorp.com/terraform/language/settings for details';
 };
 
 declare min_required="$(tfenv-min-required "${TFENV_DIR:-$(pwd)}")";