Skip to content

chore: remove-project-json #495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 14 commits into
base: develop
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
15 changes: 4 additions & 11 deletions .changeset/config.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,21 +7,14 @@
}
],
"commit": false,
"fixed": [["@forgerock/javascript-sdk", "@forgerock/ping-protect"]],
"fixed": [],
"linked": [],
"access": "public",
"baseBranch": "master",
"updateInternalDependencies": "patch",
"ignore": [
"@forgerock/device-client",
"autoscript-apps",
"autoscript-suites",
"davinci-app",
"mock-api",
"token-vault-app",
"@forgerock/token-vault-interceptor",
"token-vault-proxy",
"token-vault-suites",
"davinci-suites"
"@forgerock/davinci-app",
"@forgerock/davinci-suites",
"@forgerock/mock-api-v2"
]
}
31 changes: 11 additions & 20 deletions .eslintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,35 +17,19 @@
"depConstraints": [
{
"sourceTag": "scope:app",
"onlyDependOnLibsWithTags": [
"scope:sdk",
"scope:package",
"scope:token-vault"
]
"onlyDependOnLibsWithTags": ["scope:package"]
},
{
"sourceTag": "scope:e2e",
"onlyDependOnLibsWithTags": ["scope:sdk, scope:app"]
},
{
"sourceTag": "scope:sdk",
"onlyDependOnLibsWithTags": []
"onlyDependOnLibsWithTags": ["scope:app"]
},
{
"sourceTag": "scope:package",
"onlyDependOnLibsWithTags": ["scope:sdk"]
},
{
"sourceTag": "scope:token-vault",
"onlyDependOnLibsWithTags": [
"scope:sdk",
"scope:lib",
"scope:types"
]
"onlyDependOnLibsWithTags": []
},
{
"sourceTag": "scope:types",
"onlyDependOnLibsWithTags": ["scope:sdk"]
"onlyDependOnLibsWithTags": []
}
]
}
Expand Down Expand Up @@ -85,6 +69,13 @@
"files": "*.json",
"parser": "jsonc-eslint-parser",
"rules": {}
},
{
"files": ["./package.json", "./generators.json"],
"parser": "jsonc-eslint-parser",
"rules": {
"@nx/nx-plugin-checks": "error"
}
}
],
"parser": "@typescript-eslint/parser",
Expand Down
10 changes: 5 additions & 5 deletions .github/labeler.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,13 @@ NX:
root:
- '*'

samples:
- samples/**/*
davinci-client:
- packages/davinci-client/*

sdk:
- packages/javascript-sdk/*
- packages/javascript-sdk/**/*
device-client:
- packages/device-client/*

ping-protect: -packages/ping-protect/*
test:
- e2e/**/*
- jest*
Expand Down
5 changes: 2 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:

# This line enables distribution
# The "--stop-agents-after" is optional, but allows idle agents to shut down once the "e2e-ci" targets have been requested
- run: pnpm dlx nx-cloud start-ci-run --distribute-on="5 linux-medium-js" --stop-agents-after="e2e-ci" --verbose
- run: pnpm dlx nx-cloud start-ci-run --distribute-on=".nx/workflows/dynamic-changesets.yml" --stop-agents-after="e2e-ci" --verbose

- run: pnpm exec playwright install

Expand All @@ -46,6 +46,5 @@ jobs:
with:
name: playwright-report
path: |
./dist/.playwright/**
./dist/**
./**/.playwright/**
retention-days: 30
21 changes: 0 additions & 21 deletions .github/workflows/labeler.yml

This file was deleted.

5 changes: 2 additions & 3 deletions .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:

# This line enables distribution
# The "--stop-agents-after" is optional, but allows idle agents to shut down once the "e2e-ci" targets have been requested
- run: pnpm dlx nx-cloud start-ci-run --distribute-on="5 linux-medium-js" --stop-agents-after="e2e-ci" --verbose
- run: pnpm dlx nx-cloud start-ci-run --distribute-on=".nx/workflows/dynamic-changesets.yml" --stop-agents-after="e2e-ci" --verbose

- run: pnpm exec playwright install

Expand All @@ -55,8 +55,7 @@ jobs:
with:
name: playwright-report
path: |
./dist/.playwright/**
./dist/**
./**/.playwright/**
retention-days: 30

- run: git status
Expand Down
7 changes: 1 addition & 6 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,9 @@
tmp/
e2e/**/dist
*/dist/*
**/dist
dist/*
packages/*/dist/
packages/javascript-sdk/lib-esm
packages/javascript-sdk/lib
packages/javascript-sdk/bundle/
e2e/token-vault-app/public/*.js
e2e/token-vault-app/public/*.json
e2e/token-vault-app/public/assets/
bundles/
docs/
coverage/
Expand Down
7 changes: 4 additions & 3 deletions .nx/workflows/dynamic-changesets.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
distribute-on:
small-changeset: 3 linux-medium-js
medium-changeset: 6 linux-medium-js
large-changeset: 10 linux-medium-js
small-changeset: 3 linux-medium-js # Distribute on small if 1-25% of projects affected in PR
medium-changeset: 6 linux-medium-js # Distribute on medium if 26-50% of projects affected in PR
large-changeset: 10 linux-medium-js # Distribute on large if 51-75% of projects affected in PR
extra-large-changeset: 15 linux-medium-js # Distribute on extra-large if 76-100% of projects affected in PR
6 changes: 5 additions & 1 deletion .prettierignore
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,8 @@
package-lock.json
*/*/package-lock.json
.husky/*
/.nx/workspace-data
/.nx/workspace-data
pnpm-lock.yml
packages/*/dist
e2e/*/dist
*/dist
4 changes: 0 additions & 4 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,9 +1,5 @@
# ForgeRock Javascript SDK Changelogs

[ForgeRock Javascript SDK package](./packages/javascript-sdk/CHANGELOG.md)

[ForgeRock Token Vault package](./packages/token-vault/CHANGELOG.md)

[ForgeRock Ping Protect package](./packages/ping-protect/CHANGELOG.md)

[ForgeRock DaVinci Client package](./packages/davinci-client/CHANGELOG.md)
31 changes: 31 additions & 0 deletions contributing_docs/creating-a-package.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
# Creating a package

We have a local plugin to create packages within the repository. This document will explain the options when creating a package.

## How to generate a package

There is a `pnpm` command to create a package. `pnpm create-package`.

## Options

You will be provided with several prompts when creating the package.

The only required prompt is a `name`. This is the `package` name and the file-system name.

### Optional prompts

`scope`: this is the `npm` scope that will be interpolated into the `package.json` `name` field. Do not include the `@` symbol, it is added automatically.

`sideEffects`: This is to ensure packages are tree shakeable. `false` sets the the value to `false`. If you intend to have `sideEffects` you can set it to `true`. however this will mark _every_ file as a side effect. It's best to edit this afterwards on your own if the value is not `false`.

`description`: If you want to add a description of the package in the `package.json`, `description` field.

`moduleType`: This sets the `module` type. Either `commonjs` or `module` are valid entries. Default is `module`

`outputDir`: This sets up the `output` directory. by default, it is set to `dist`. This typically shouldn't need to be changed.

## Notes

All packages are marked as `private` by default. This is to prevent unwanted publishing. It is the developer's responsibility to mark a package as public when ready to publish. See [releases](./releases.md) for more information on releases.

All packages are by default setup to used `tsc`. Other build tools can be used after the generator is run. If its requested to add a generator or option for using `vite` or something else, please reach out to @ryanbas21 or add the feature in yourself and PR it.
3 changes: 0 additions & 3 deletions e2e/autoscript-apps/.babelrc

This file was deleted.

11 changes: 0 additions & 11 deletions e2e/autoscript-apps/.eslintignore

This file was deleted.

4 changes: 0 additions & 4 deletions e2e/autoscript-apps/.eslintrc.json

This file was deleted.

13 changes: 0 additions & 13 deletions e2e/autoscript-apps/browserslist

This file was deleted.

75 changes: 0 additions & 75 deletions e2e/autoscript-apps/index.html

This file was deleted.

22 changes: 0 additions & 22 deletions e2e/autoscript-apps/package.json

This file was deleted.

Loading
Loading