-
Notifications
You must be signed in to change notification settings - Fork 435
feat: Allow task processor to have its own database #5406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
Uffizzi Ephemeral Environment Deploying☁️ https://app.uffizzi.com/github.com/Flagsmith/flagsmith/pull/5406 ⚙️ Updating now by workflow run 14917815120. What is Uffizzi? Learn more! |
9e7caa8
to
f29b8bd
Compare
Codecov ReportAttention: Patch coverage is
❌ Your patch check has failed because the patch coverage (71.66%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #5406 +/- ##
==========================================
- Coverage 97.63% 97.59% -0.04%
==========================================
Files 1234 1234
Lines 42992 43052 +60
==========================================
+ Hits 41974 42017 +43
- Misses 1018 1035 +17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but there are a couple of general comments:
- I'd love to see in the description confirmation that this has been tested manually
- We should add these new settings to the docs
|
||
|
||
class TaskProcessorRouter: | ||
""" | ||
Routing of database operations for task processor models | ||
|
||
This router is used if TASK_PROCESSOR_DATABASE_* settings are defined. | ||
""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Flagsmith/flagsmith-back-end It makes sense for this router to live here, because the behavior is demanded by the API specifically. However, because it looks very standard for now, it feels like it could be offered by flagsmith-common. What's the team opinion on this? I'm happy to go either path, though I believe testing and docs would be easier if contained in flagsmith[-core].
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, moved to flagsmith-common (Flagsmith/flagsmith-common@ec6c2e5), as it was actually necessary. I will update this PR next time I'm working on this, likely on Monday, and resolve this thread afterwards.
Fixes #5136.
Thanks for submitting a PR! Please check the boxes below:
docs/
if required so people know about the feature!Changes
Based on the original issue (#5136) description.
How did you test this code?