Skip to content

feat: frontend-clone-segments 🔴 Blocked by #5393 #5394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Zaimwa9
Copy link
Contributor

@Zaimwa9 Zaimwa9 commented Apr 25, 2025

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

🔴 Blocked by #5393 (feat/backend-clone-segments)

This PR implements the frontend part to consume the new clone segment API endpoint and allow the duplication of existing segments

  • ⚠️ Introduces new flag clone_segment

  • Reviewed UI to use a dropdown instead of trash button in SegmentRow

  • cloneSegment mutation to consume /api/v1/projects/{projectId}/segments/{segmentId}/clone/ accepting a (required) name as body payload

  • Refactored SegmentsPage to extract SegmentRow

  • Extracted ActionItem as single component, calculateListPosition as utils

How did you test this code?

  • New E2E tests
  • Postman requests
  • Fullstack branch feat/clone-segments-and-feature-segments
image

Project Segment creation
https://www.loom.com/share/27ec8d4a2d8d4c24b443ac5d2b12231e?focus_title=1&muted=1&from_recorder=1

Feature specific segment creation
https://www.loom.com/share/8cc4d8e92ce84c459dfb6598ebb42acb

@Zaimwa9 Zaimwa9 requested a review from a team as a code owner April 25, 2025 14:36
@Zaimwa9 Zaimwa9 requested review from kyle-ssg and removed request for a team April 25, 2025 14:36
Copy link

vercel bot commented Apr 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 1, 2025 3:48pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 1, 2025 3:48pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview May 1, 2025 3:48pm

@Zaimwa9 Zaimwa9 marked this pull request as draft April 25, 2025 14:36
@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label Apr 25, 2025
Copy link
Contributor

github-actions bot commented Apr 25, 2025

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith:pr-5394 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-5394 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api-test:pr-5394 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-5394 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-5394 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-5394 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-5394 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-5394 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-5394 Finished ✅ Results

@github-actions github-actions bot added the feature New feature or request label Apr 25, 2025
Copy link
Contributor

github-actions bot commented Apr 25, 2025

Uffizzi Ephemeral Environment deployment-63157

☁️ https://app.uffizzi.com/github.com/Flagsmith/flagsmith/pull/5394

📄 View Application Logs etc.

What is Uffizzi? Learn more!

@Zaimwa9 Zaimwa9 changed the title feat: frontend-clone-segments feat: frontend-clone-segments 🔴 Blocked by #5393 Apr 25, 2025
@Zaimwa9 Zaimwa9 marked this pull request as ready for review April 28, 2025 10:30
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Apr 28, 2025
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels May 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants