Skip to content

feat: User permissions summary #5247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

feat: User permissions summary #5247

wants to merge 8 commits into from

Conversation

kyle-ssg
Copy link
Member

@kyle-ssg kyle-ssg commented Mar 25, 2025 •
edited
Loading

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Whilst we decide on #5224, this adds a stop-gap improvement where we summarise user-level permissions in the environment and project settings pages.

image

Caveats:

  • This shows a tooltip explaining what No permissions means (i.e. there could be some at the group/role level)
  • This will not show at the organisation settings level since here we show a list of projects / environments.

How did you test this code?

View permissions from project/environment settings

@kyle-ssg kyle-ssg requested a review from a team as a code owner March 25, 2025 17:47
@kyle-ssg kyle-ssg requested review from tiagoapolo and removed request for a team March 25, 2025 17:47
@vercel Vercel
Copy link

vercel bot commented Mar 25, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 29, 2025 2:58pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 29, 2025 2:58pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Apr 29, 2025 2:58pm

@github-actions github-actions bot added front-end Issue related to the React Front End Dashboard feature New feature or request labels Mar 25, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 25, 2025 •
edited
Loading

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-5247 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-5247 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-5247 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-5247 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-5247 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-5247 Finished ✅ Results ✅

@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Mar 25, 2025
@kyle-ssg kyle-ssg linked an issue Mar 25, 2025 that may be closed by this pull request
UI improvements in project / environment permission configuration #5237
Open
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 25, 2025 •
edited
Loading

Uffizzi Ephemeral Environment deployment-62215

☁️ https://app.uffizzi.com/github.com/Flagsmith/flagsmith/pull/5247

📄 View Application Logs etc.

What is Uffizzi? Learn more!

@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Apr 9, 2025
@matthewelwell
Copy link
Contributor

I can't see where the extra commas are coming from but there's some issue with the content in the tooltip:

image

Also, there's an example here of a user (Daniel) that is marked as having no user-level permissions, but is seemingly an administrator when you click into his user permissions?

image image

@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Apr 15, 2025
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Apr 15, 2025
@kyle-ssg
Merge branch 'refs/heads/main' into feat/user-permission-summaries
f2ceb58 
# Conflicts:
#	frontend/common/stores/account-store.js
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Apr 16, 2025
matthewelwell
matthewelwell approved these changes Apr 17, 2025
View reviewed changes
Copy link
Contributor

@matthewelwell matthewelwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a minor formatting comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiagoapolo tiagoapolo tiagoapolo approved these changes

@matthewelwell matthewelwell matthewelwell approved these changes

@rolodato rolodato Awaiting requested review from rolodato

@Zaimwa9 Zaimwa9 Awaiting requested review from Zaimwa9

Assignees
No one assigned
Labels
feature New feature or request front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UI improvements in project / environment permission configuration
3 participants
@kyle-ssg @matthewelwell @tiagoapolo