reset p1 and p2 to null after 2nd click #131
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maybe it will make it register p1 for every odd clicks and p2 for every even clicks
Contributor
Author
BalaM314
requested changes
Oct 4, 2025
| const height = Math.abs(p1[1] - p2[1]); | ||
| if(width > 50 || height > 50) fail("Selection too large: width/height cannot be more than 50."); | ||
| handleArea(p1, p2); | ||
| p1 = null; |
Member
There was a problem hiding this comment.
This won't do anything. p1 is just a temporary variable. You need to modify cachedPointMap to clear the data
Contributor
Author
There was a problem hiding this comment.
e
11:30pm rn im under a blanket while typing on a phone
cuz my mom moved into mah room now (for reasons)
Member
|
implemented in #133 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
maybe it will make it register p1 for every odd clicks and p2 for every even clicks