Skip to content

Remove the check in loadInventoryPage #8542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove the check in loadInventoryPage #8542

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions src/jrd/tpc.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,12 +314,6 @@ void TipCache::loadInventoryPages(thread_db* tdbb, GlobalTpcHeader* header)
header->oldest_transaction.store(hdr_oldest_transaction, std::memory_order_relaxed);
header->latest_attachment_id.store(hdr_attachment_id, std::memory_order_relaxed);

// Check if TIP has any interesting transactions.
// At database creation time, it doesn't and the code below breaks
// if there isn't a single one transaction to care about.
if (hdr_oldest_transaction >= hdr_next_transaction)
return;

// Round down the oldest to a multiple of four, which puts the
// transaction in temporary buffer on a byte boundary
TraNumber base = hdr_oldest_transaction & ~TRA_MASK;
Expand Down
Loading