Don't generate 3 band resistor when it can't represent the value #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
I agree with this change, just out of curiousity, what resistors do you own that this is relevant for? E3/E6/E12/E24 don't have any that need more than two digits. |
Finomnis
reviewed
Jul 23, 2025
Finomnis
reviewed
Jul 24, 2025
| num_codes: int, | ||
| tolerance_value: Optional[float], | ||
| ) -> None: | ||
| if value.ohms_val % (10 ** (4 - num_codes)): |
Owner
There was a problem hiding this comment.
Would you mind adding a comment before this if? Like # Only display resistors that can accurately represent the given value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch prevents the generation of 3 band resistor images for values it can't accurately represent.