Skip to content

feat: add ClipSet to schema #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat: add ClipSet to schema #90

wants to merge 1 commit into from

Conversation

adgad
Copy link
Collaborator

@adgad adgad commented Jul 23, 2025

This is a draft PR for what I think the Clips Schema should be (based on earlier work #86 and what is currently in Workarounds).

There's a few considerations / changes to how it currently works:

  1. Rename dataLayout to layoutWidth for consistency with other nodes
    a. ClipSet only allows a limited number of layouts, I assume that is intentional?
  2. There is a challenge around transcripts, which is currently modelled as a nested body. In the current component in cp-content-pipeline-ui, it is expecting another RichText graphql type (which has a graphql-ish data structure with fields like raw, structured, references). I'm not really sure how we model that in content-tree, or if. If we need content-tree to be different to cp-content-pipeline (i.e. maintain a workaround), that would also mean the UI component itself isn't really transferable.
  3. Similarly, the transcript currently is a with only text. Our current Body node in content-tree doesn't allow Text as a top level node - should it? Or should it be a separate thing?
    a. note - live events also do this, but i've been ignoring them for now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant