Skip to content

Fix clicking on parts of annotations that are in a different element tha... #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix clicking on parts of annotations that are in a different element tha... #24

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions app/assets/javascripts/sidebar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,9 +130,8 @@ Sidebar.AnnotationListView = Backbone.View.extend({
$("span.annotator-hl").click(function(event) {
$("ul#annotation-list li").removeClass('hover');
$("span.highlightlink").tooltip('hide');
var str = this.id.toString();
var parts = str.match(/(hl)(.+)/).slice(1);
var targetid = "#sb" + parts[1];
var uuid = $(this).data('annotation').uuid;
var targetid = "#sb" + uuid;

// TODO: deal with the events in a more organized way (recompose them in functions)
$('div#annotation-well').animate({scrollTop:$(targetid).offset().top}, 100, function (){
Expand Down