-
Notifications
You must be signed in to change notification settings - Fork 12
Gas Snapshot #193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gas Snapshot #193
Conversation
PayeeRailsTest:testEmptyResult() (gas: 57771) | ||
PayeeRailsTest:testGetRailsForPayeeAndToken() (gas: 149980) | ||
PayeeRailsTest:testEmptyResult() (gas: 57793) | ||
PayeeRailsTest:testGetManyRails() (gas: 130853979) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like creating new rails is especially expensive
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's just a bunch of memory write operations and an event emission. Any idea why this would be ? It's all in the createRail
function if you wanna take a look. (But this is not a high priority right now, totally your call man).
@wjmelements Wdym ? You can just open a PR to update those numbers as the doc lives in this repo (pretty sure I'm missing something here). |
""" Dosen't it also help increase network revenue for token holders if the gas token is the same as chain token ? |
It would be best if we could run a script (such as forge snapshot) to update those numbers automatically. Then it would be easy to see how much a PR impacts gas. |
If the payments are more efficient, the network can do more of them, and we can supply them more sustainably and competitively. This is the supply side. If payments are too expensive, existing and potential users will choose cheaper alternatives. This is the demand side. |
Thanks for your replies man ! We don't have this setup right now. But it would be awesome to have it. Please feel free to raise a PR (can do it as part of this PR as well) and we can then merge the whole thing together 👍 |
Closing in favor of #207 |
Reviewer @aarshkshah1992
Gas roughly measures the burden of operations on the network, so we want to reduce it.
Although filecoin gas won't be the same as Ethereum, measuring the ethereum gas will provide a way to know to what extent a change reduces gas.
Changes