Skip to content

bugfix: max number of unique connections #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

bugfix: max number of unique connections #24

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion difflogic/functional.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,9 @@ def get_unique_connections(in_dim, out_dim, device='cuda'):
'({}) because otherwise not all inputs could be used or considered.'.format(
out_dim, in_dim
)
n_max = int(in_dim * (in_dim - 1) / 2)
assert out_dim <= n_max, 'The number of neurons ({}) must not be greater than the number of pair-wise combinations ' \
'of the inputs ({})'.format(out_dim, n_max)

x = torch.arange(in_dim).long().unsqueeze(0)

Expand All @@ -100,7 +103,7 @@ def get_unique_connections(in_dim, out_dim, device='cuda'):

# If this was not enough, take pairs with offsets >= 2:
offset = 2
while out_dim > a.shape[-1] > offset:
while out_dim > a.shape[-1]:
a_, b_ = x[..., :-offset], x[..., offset:]
a = torch.cat([a, a_], dim=-1)
b = torch.cat([b, b_], dim=-1)
Expand Down