Skip to content

Conversation

@Vylantze
Copy link

@Vylantze Vylantze commented Sep 7, 2025

#2107

  • Added a fallback for when Support fails to be detected
  • Add more support images (Failed, I was not able to make it work)

Support fallback

2025-09-07_19-04-26.Support.servant.fallback.compressed.mp4

@github-actions
Copy link

github-actions bot commented Sep 7, 2025

Build 496

Download the latest APK for testing here

Note

You need a GitHub account to download the APK.

This URL is valid as long as the artifact has not expired yet.

@ArthurKun21 ArthurKun21 requested a review from reconman September 7, 2025 12:25
@Vylantze
Copy link
Author

Vylantze commented Sep 7, 2025

Narrowed the support region. I have also attempted to add new support images, but to no avail (it didn't work for the case above).

New region
image
2025-09-08.Sample.region.mp4
New support images (that have failed)
support_2 support_3

@muscularcandy67
Copy link

I am aware that it could be a lot of work, but I think it can be done by splitting the support icon by letter and if a % (eg 60%) is matched then it's support, otherwise it's not.

@Vylantze
Copy link
Author

I am aware that it could be a lot of work, but I think it can be done by splitting the support icon by letter and if a % (eg 60%) is matched then it's support, otherwise it's not.

The problem is that the less letters there are, the less unique the pattern becomes. With the images I already tried, it was already unable to distinguish between a normal card and a support card.

The problem is that I am not sure why these additional support images are not being detected when it appears unique enough to the human eye. The logic behind the detection and the relationship between the region and reference image are things I am completely unaware of after all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants