-
-
Notifications
You must be signed in to change notification settings - Fork 205
Uniform refinement of mixed topology meshes #3756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not quite done reviewing, but here are my initial comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should maybe the entry point for uniform_refine
and the already present refine
share a common API? refine
already supports uniform refinements by marking of all edges, and in the future the refinement routines implemented here could be extended to non uniform cases.
Also the partitioner creation, especially for refinement aware identity_partitioner
to come #3661, should be available for the uniform refinement. This would be easiest to accomplish if the entry point is a shared one.
About unifying the interface: For some near future PRs, we can look at:
|
Allows mixed topology meshes, e.g. triangle+quad, or hex+pyramid+prism+tet to be refined globally.
This also works for pure or quad hex meshes, for example.