Skip to content

Remove dynamic memory allocations inside lowest level assembly functions #3746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 30 commits into
base: main
Choose a base branch
from

Conversation

garth-wells
Copy link
Member

This will allow the lowest lever assembly functions to be executed efficiently for small batches of cells.

Also makes a number of simplifications following careful review of code.

@michalhabera
Copy link
Contributor

It would be also neat to check no heap allocation in certain scopes. Clang (>=19) has [[clang::nonallocating]] attribute, https://clang.llvm.org/docs/FunctionEffectAnalysis.html#the-nonblocking-and-nonallocating-attributes
Requires extra -Wfunction-effects pass.

@schnellerhase
Copy link
Contributor

That flag could be passed to the clang-tidy linting run in #3722. Clang tidy hooks into a LLVM based compile anyways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants