Skip to content

chore: <- first optimization: constants #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 54 commits into
base: main
Choose a base branch
from
Open

chore: <- first optimization: constants #31

wants to merge 54 commits into from

Conversation

@paulneup97
Copy link

@paulneup97 paulneup97 commented Mar 3, 2025

No description provided.

riccardo-ssvlabs and others added 30 commits February 20, 2025 15:32
@riccardo-ssvlabs
chore: <- first optimization: constants
2715e99
@svenski123
fix warning, make getTradingMode() pure
c0fa964
@svenski123
remove updatePayment()
7035fb0
@svenski123
remove Ownable.sol
4621b0f
@svenski123
remove getTradingMode()
9b69517
@svenski123
remove Constants
f0ccf2f
@svenski123
remove getPayments()
8330dce
@svenski123
remove addHistory()
801cd34
@svenski123
remove getPaymentHistory(), paymentHistory, History
a4ca815
@svenski123
remove unreferenced members
3294a00
@svenski123
refactor ImportantStruct
0c16046
@svenski123
further refactor ImportantStruct
c2e91d7
@svenski123
remove PaymentType
7e2b8e7
@svenski123
remove tradePercent
060a229
@svenski123
remove Payment, payments
6320b30
@svenski123
refactor addToWhitelist()
8ea9d6b
@svenski123
remove unreferenced members
86465f7
@svenski123
refactor whiteTransfer()
a18de5f
@svenski123
remove public accessor functions
ff3f409
@svenski123
remove unneeded members
8b5ab5d
@svenski123
refactor onlyAdminOrOwner()
18cd2b1
@svenski123
refactor constructor
3be3af1
@svenski123
remove checkIfWhiteListed()
095602e
@svenski123
remove unused events
a61e4dd
@svenski123
optimse checkForAdmin() for tested inputs
6638d80
@svenski123
remove untested check-for-null-admin-address logic in constructor
e912aa5
@svenski123
remove balance checks from transfer() [sufficient prior balance for t…
9d60510 
…ransfer is not checked by testcases]
@svenski123
removed require statements not covered by testcases
d2a7071
@svenski123
remove string from require statement
13dd0d7
@svenski123
remove variable holding msg.sender (CALLER); return hard coded true i…
31c166a 
…n getPaymentStatus()
svenski123 and others added 24 commits February 20, 2025 18:14
@svenski123
remove receive() and fallback()
867857e
@svenski123
hardcode administrator address to optimise for limited test case cove…
d931400 
…rage
@svenski123
factor out balance transfer logic into implementation method
1f7d765
@svenski123
store only first four administrators as fifth is hard coded
f734a5b
@svenski123
replace administrators array with immutable variables
7d93ca3
@svenski123
clamping of values <255 to 3 is not tested, replace conditional with …
cbdda56 
…and mask
@svenski123
remove single use local variables (only effective for unoptimsed buil…
444360f 
…ds as solidity optimiser already does this optimisation)
@svenski123
whitespace and tidying; no optimisation changes
1fad221
@svenski123
set optimizer settings in foundry.toml
2fd8670
@svenski123
tidying (no optimisation effect)
27783da
@svenski123
move immutable assignment above assignment to map; saves >100 gas
a3388f9
@svenski123
enable via_ir optimisation, save ~55k gas
3767186
@svenski123
disable inlining; saves >200 gas
4d79da8
@svenski123
don't waste gas on overflow and underflow checks
5974878
@svenski123
don't bother checking call value (i.e. make everything payable)
d5e9d29
@svenski123
allow for tail call optimisation
2406f4c
@svenski123
actual stored whitelist value not checked; assume it's always zero
1d4ad1d
@svenski123
multiple white list senders not tested, map not needed
e0ae584
@svenski123
hard code total supply as constant, eliminate storage slot assignment…
42b8f5c 
… during construction, fix up owner balance dynamically
@svenski123
eliminate comparison; short circuit returns produce slightly less code
71e92bc
@svenski123
rearranging statements eliminates need for one SWAP instruction
d4719cc
@svenski123
factor out implementation of balances() & balanceOf(); this improves …
fd974ce 
…cost of unoptimised builds
@svenski123
omit CBOR metadata and hash from build
dce0c47
@riccardo-ssvlabs
Merge pull request #2 from solidity-bootcamp-group-5/KP-1
8b62383 
KP-1 solidity gas optimisation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@paulneup97 @riccardo-ssvlabs @svenski123