Add Custom Emojis with Unicode Private User Area with a new font #59301

c3024 · 2025-03-28T14:26:06Z

Explanation of Change

This PR implements Custom Emojis using the Private User Area Unicodes. This is part of #54643 implementation in which we add a custom emoji font containing :global_create: emoji. Two fonts CustomEmojiWebFont.ttx and CustomEmojiNativeFont.ttx are created with private user area codes allotted to different SVGs with nanoemoji. The fonts are added as per this document.

Emoji regex was updated on expensify-common. Hybrid [PR]https://github.com/Expensify/Mobile-Expensify/pull/13570) for adding these fonts here.

Fixed Issues

$ #54643
PROPOSAL: https://expensify.slack.com/archives/C07HPDRELLD/p1742914747461099?thread_ts=1742275825.663609&cid=C07HPDRELLD

MOBILE-EXPENSIFY: https://github.com/Expensify/Mobile-Expensify/pull/13570

Tests

Enter :global in the composer.
Verify that the suggestions show global_create (FAB) emoji.
Enter :global_create: in the composer.
Verify that it changes to FAB emoji.
Send a message with only this emoji :global_create: and this emoji with some text.
Verify that the behaviour of custom emojis in these sent messages, and LHN are same as that of regular emojis.

Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Same as Tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

globalCreateAndroid.mov

Android: mWeb Chrome

globalCreateAndroidmWeb.mov

iOS: Native

globalCreateiOS.mov

customEmojiiOS.mov

iOS: mWeb Safari

globalCreateiOSmWeb.mov

MacOS: Chrome / Safari

globalCreateChrome.mov

MacOS: Desktop

globalCreateDesktop.mov

github-actions · 2025-03-28T14:26:19Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

github-actions · 2025-03-28T14:29:37Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

github-actions · 2025-03-28T16:31:06Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

github-actions · 2025-03-31T11:57:20Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

github-actions · 2025-04-06T08:40:10Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

github-actions · 2025-04-06T12:01:21Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

github-actions · 2025-04-06T12:33:37Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

github-actions · 2025-04-06T12:40:21Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

github-actions · 2025-04-06T12:42:21Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

github-actions · 2025-04-06T12:51:15Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

github-actions · 2025-04-06T12:52:53Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

github-actions · 2025-04-06T12:58:04Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

github-actions · 2025-04-06T13:01:22Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

grgia · 2025-07-08T15:30:28Z

@eVoloshchak would you please do a final review 🙇

eVoloshchak · 2025-07-08T17:22:47Z

@c3024, we call containsCustomEmoji function for every comment and every OptionRow. I wonder what are the performance implications of that
We do it only to apply custom styles for the custom font, is that right?
Might there be something wrong with the font if we don't need the same custom styles for other fonts? Can we apply those custom styles in the font itself so we don't rely on containsCustomEmoji function?

c3024 · 2025-07-09T04:45:03Z

@eVoloshchak

we call containsCustomEmoji function for every comment and every OptionRow. I wonder what are the performance implications of that

I’ve looked into this, and from what I found and understood, it’s not a problem. The regex is lightweight and the check should be performant. I haven’t seen any issues during testing on high-traffic accounts. That said, I also pushed changes to memoize the usage to avoid unnecessary repeated calls.

We do it only to apply custom styles for the custom font, is that right?

The existing fonts in the app don’t include emojis, and standard emojis are rendered natively by the platform. Including the custom emojis directly in the existing fonts could have avoided this additional styling, but we decided to avoid that approach.

On native platforms, a specific font must be applied to text—fallbacks don’t work. So we need to explicitly apply the custom font only to the custom emojis. If we applied this font to all strings, non-emoji text would fall back to the system font, which would break our styles.

I don’t think there’s anything wrong with the custom font itself, and we can’t embed these conditional styles directly into the font.

eVoloshchak · 2025-07-09T12:37:08Z

and we can’t embed these conditional styles directly into the font.

Fair enough, thank you for the clarification

The new font isn't displayed in Safari

or on Native iOS

c3024 · 2025-07-09T12:46:54Z

It shows correctly on iOS Safari for me.

c3024 · 2025-07-09T12:51:34Z

On iOS too.

@eVoloshchak

Are you checking with the latest Adhoc build?

eVoloshchak · 2025-07-09T12:54:24Z

@c3024, could you check this in a phone simulator too?
And which iOS version are you testing? Mine is 17.0, but I don't think that should make any difference

c3024 · 2025-07-09T12:56:23Z

iPad OS 18.3.2

c3024 · 2025-07-09T13:01:39Z

On simulator

grgia · 2025-07-09T15:00:45Z

Approving, but will wait on @eVoloshchak's confirmation

eVoloshchak

Don't see this bug on a physical device, but it's definitely there on a Simulator, which is weird.
Approving as it works as expected on a real device

grgia · 2025-07-10T09:04:24Z

Gonna merge these then! Great work on this @c3024 and thank you for thoroughly testing this @eVoloshchak

OSBotify · 2025-07-10T09:15:43Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-07-11T18:06:12Z

🚀 Deployed to staging by https://github.com/grgia in version: 9.1.80-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

nlemma · 2025-07-11T18:22:04Z

@c3024 This PR is failing with this issue.

github-actions · 2025-07-15T03:00:01Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.1.80-8 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

c3024 added 3 commits March 26, 2025 18:14

add Unicode custom emojis

16be069

add custom emoji to Android

24b31a4

apply Unicode Emojis for Native apps

9d64927

update missing files

46fc170

fix LHN subtitles and custom emojis on Safari

209a1c3

c3024 changed the title ~~Add unicode custom emojis~~ Add Custom Emojis with Private User Area Mar 28, 2025

fix native app emoji only style, update constants

a8abe7a

update android,ios,unicode,diff fonts for native

f80ca12

add a temporary patch to testing custom emojis

6784b82

remove ununsed font files

80dc51b

add back accidentally removed xcshareddata files

e3f4a27

revert the removed lock files

0aa1640

c3024 force-pushed the add-Unicode-custom-emojis branch from e95f08a to 0aa1640 Compare April 6, 2025 12:50

prettier

4b80502

add back plist and xcsettings files

cb0be92

remove link assets dev dependency

ca49619

remove linking changes in react-native.config.js

e542e3b

memoize custom emoji function uses

55f7488

c3024 dismissed grgia’s stale review via 55f7488 July 9, 2025 04:36

Merge branch 'main' into add-Unicode-custom-emojis

ce87f43

lint fix

5e142be

grgia approved these changes Jul 9, 2025

View reviewed changes

eVoloshchak approved these changes Jul 9, 2025

View reviewed changes

melvin-bot bot requested a review from roryabraham July 9, 2025 16:40

grgia merged commit af422c7 into Expensify:main Jul 10, 2025
26 of 27 checks passed

github-actions bot mentioned this pull request Jul 11, 2025

Deploy Checklist: New Expensify 2025-07-11 #65958

Closed

73 tasks

nlemma mentioned this pull request Jul 11, 2025

[Due for payment 2025-07-22] Chat - Thread header shows a broken icon instead of global create emoji #65965

Closed

8 tasks

c3024 mentioned this pull request Jul 15, 2025

Fix custom emoji for Android app #66125

Merged

50 tasks

Julesssss mentioned this pull request Jul 15, 2025

Deploy Checklist: New Expensify 2025-04-29 Expensify/App-Test-Fork#56

Closed

68 tasks

mitarachim mentioned this pull request Jul 17, 2025

[Due for payment 2025-08-15] [Due for payment 2025-08-13] [$250] Expense - Report field shows a broken icon instead of the custom global create emoji #66602

Closed

8 tasks

joekaufmanexpensify mentioned this pull request Jul 17, 2025

Emoji - Global create emoji is grouped under flags section #66616

Closed

8 tasks

shawnborton mentioned this pull request Oct 16, 2025

[Due for payment 2025-10-23] [Due for payment 2025-10-22] [CFI] Add primary receipt scan option on mobile and web #72030

Open

Add Custom Emojis with Unicode Private User Area with a new font #59301

Add Custom Emojis with Unicode Private User Area with a new font #59301

Uh oh!

Conversation

c3024 commented Mar 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

github-actions bot commented Mar 28, 2025

Uh oh!

github-actions bot commented Mar 28, 2025

Uh oh!

github-actions bot commented Mar 28, 2025

Uh oh!

github-actions bot commented Mar 31, 2025

Uh oh!

github-actions bot commented Apr 6, 2025

Uh oh!

github-actions bot commented Apr 6, 2025

Uh oh!

github-actions bot commented Apr 6, 2025

Uh oh!

github-actions bot commented Apr 6, 2025

Uh oh!

github-actions bot commented Apr 6, 2025

Uh oh!

github-actions bot commented Apr 6, 2025

Uh oh!

github-actions bot commented Apr 6, 2025

Uh oh!

github-actions bot commented Apr 6, 2025

Uh oh!

github-actions bot commented Apr 6, 2025

Uh oh!

grgia commented Jul 8, 2025

Uh oh!

eVoloshchak commented Jul 8, 2025

Uh oh!

c3024 commented Jul 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

eVoloshchak commented Jul 9, 2025

Uh oh!

c3024 commented Jul 9, 2025

Uh oh!

c3024 commented Jul 9, 2025

Uh oh!

eVoloshchak commented Jul 9, 2025

Uh oh!

c3024 commented Jul 9, 2025

Uh oh!

c3024 commented Jul 9, 2025

Uh oh!

grgia commented Jul 9, 2025

Uh oh!

eVoloshchak left a comment

Choose a reason for hiding this comment

Uh oh!

grgia commented Jul 10, 2025

Uh oh!

Uh oh!

OSBotify commented Jul 10, 2025

Uh oh!

github-actions bot commented Jul 11, 2025

Uh oh!

nlemma commented Jul 11, 2025

Uh oh!

github-actions bot commented Jul 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

c3024 commented Mar 28, 2025 •

edited

Loading

c3024 commented Jul 9, 2025 •

edited

Loading