Skip to content

B3 propagation #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

B3 propagation #10

wants to merge 2 commits into from

Conversation

@mmenindezsegura
Copy link
Contributor

@mmenindezsegura mmenindezsegura commented Aug 13, 2020

No description provided.

@kapilra
Copy link
Member

kapilra commented Aug 18, 2020

Apart from the id generation logic, propagation logic also needs to be taken care:

haystack-client-python/haystack/propagator.py

Line 26 in 38dcb76

PropagatorOpts.__new__.__defaults__ = (TRACE_ID, SPAN_ID, PARENT_SPAN_ID,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kapilra kapilra Awaiting requested review from kapilra

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mmenindezsegura @kapilra