-
Notifications
You must be signed in to change notification settings - Fork 316
feat: Allow users to disable the suffix range request #5188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: Allow users to disable the suffix range request #5188
Conversation
1. Allow users to disable the suffix range request because some storage backends do not support suffix range
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
7 files reviewed, 1 comment
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5188 +/- ##
==========================================
+ Coverage 74.05% 74.80% +0.74%
==========================================
Files 959 972 +13
Lines 124302 123714 -588
==========================================
+ Hits 92055 92539 +484
+ Misses 32247 31175 -1072
🚀 New features to boost your workflow:
|
1. fix code check
@TheR1sing3un, Is this ready for review? It appears some of the tests are still failing. Feel free to ping me or @colin-ho once the CI is passing and it's ready for a review. |
Hi!Sorry for my late response. I think the previous failure was due to some issues with the CI itself rather than the code changes. I ran it again and everything passed. Could you please review the code for me? Thank you! :) |
@universalmind303 @colin-ho hi, Could someone help me review it? Thank you very much |
At present, there are still many storage backends that do not support the
suffix range
request. I hope to still retain a parameter for users to control for themselves whether to usesuffix range
for data reading.Because some are in the form of protocols, such as S3, which is a standard protocol, many different object storage implementations will attempt to follow the S3 protocol. But, there are also many specific implementations that do not support the
suffix range
capability. We cannot directly control at the S3 level whethersuffix range
can be supportedChanges Made
Related Issues
Checklist
docs/mkdocs.yml
navigation