Fix Postgresql compatibility #2092
Open
+128
−128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backticks to indicate identifiers is non-standard and not compatible with PostgreSQL nor patched by Dolibarr migration handler.
`user` is a reserved keyword in postgresql. To indicate we want "user" as an identifier, we need to double-quote it as such. Since it's coming from a table, quote every identifier there. Quoting identifiers is a standard SQL syntax and will work on other DBMS engines.
Postgresql and standard SQL requires single 'quoting' for strings.
Postgresql and standard SQL requires single 'quoting' for strings.
Postgresql and standard SQL requires single 'quoting' for strings.
Added for postgres compatibility.
alexandre-janniaux
force-pushed
the
postgres-compatibility
branch
from
5ab6e41 to
6333a5b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge request fixes a few PostgreSQL incompatibilities that I found when setting up Digiquali.
The main point here is changing strings in SQL, so as to use the standard single-quoting instead of the mysql double-quoting.
On the migration side there is also backtick-quoting for identifiers that is mysql-specific, the standard way being double-quoting.
There is one additional issue fixed around using "user" as a table identifier in some LEFT JOIN queries, which is not possible without double-quoting (ie. marking as an identifier) since "user" is a reserved keyword in postgresql.