Skip to content

GH-1134 Add permissions allowing to ignore sleep count for night skip and phantom spawn #1135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

GH-1134 Add permissions allowing to ignore sleep count for night skip and phantom spawn #1135

wants to merge 19 commits into from
+162 −0

Conversation

Jakubk15
Copy link
Member

@Jakubk15 Jakubk15 commented Aug 19, 2025 •
edited
Loading

Resolves #1134

@Jakubk15 Jakubk15 requested a review from a team as a code owner August 19, 2025 20:03
@Jakubk15 Jakubk15 self-assigned this Aug 19, 2025
@Jakubk15 Jakubk15 added 🆕 feature New feature or request 🚀 EternalCore 2.0 Major rework and refactor for the upcoming EternalCore 2.0 release labels Aug 19, 2025
gemini-code-assist[bot]
gemini-code-assist bot reviewed Aug 19, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces new permissions to ignore sleep counting for night skipping and to prevent phantom spawning. It also includes a significant refactoring across many command classes, replacing the @Context annotation with the more specific @Sender annotation from LiteCommands. Additionally, a small bug in the teleport command has been fixed.

The new features are well-implemented with new controllers and a custom event for phantom spawning, which is a good design choice. The refactoring is consistent and improves the codebase.

I've found a couple of minor issues: a permission mismatch in the documentation and a small improvement opportunity in a new event class. Please see my detailed comments below.

@Jakubk15 Jakubk15 changed the title Add permissions allowing to ignore sleep count for night skip and phantom spawn GH-1134 Add permissions allowing to ignore sleep count for night skip and phantom spawn Aug 19, 2025
P1otrulla
P1otrulla requested changes Aug 20, 2025
View reviewed changes
Copy link
Member

@P1otrulla P1otrulla left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are these annotations doing here? To be honest, I didn't feel like reviewing over 80 files, most of which were annotations. 51d1eb5#r164269516 - my review is here

@Jakubk15
Copy link
Member Author

Sorry, seems like I created a new branch based on another PR. Will fix

Jakubk15 and others added 3 commits August 20, 2025 09:04
@Jakubk15
Add sleep controllers for ignore sleeping and preventing spawn of pha…
9d40d4e 
…ntoms when holding appropriate permission
@Jakubk15
Add a new line between static field and class declaration
f747830
@Jakubk15 @gemini-code-assist
Update eternalcore-core/src/main/java/com/eternalcode/core/feature/sl…
0deac50 
…eep/PlayerJoinSleepController.java

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@Jakubk15 Jakubk15 force-pushed the feature/ignore-sleep branch from 0236b32 to 0deac50 Compare August 20, 2025 07:05
@Jakubk15 Jakubk15 requested a review from P1otrulla August 20, 2025 07:06
P1otrulla
P1otrulla approved these changes Aug 20, 2025
View reviewed changes
Jakubk15 and others added 9 commits August 20, 2025 11:34
vLuckyyy
vLuckyyy approved these changes Aug 20, 2025
View reviewed changes
Copy link
Member

@vLuckyyy vLuckyyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you tested it?

Rollczi
Rollczi requested changes Aug 26, 2025
View reviewed changes
Jakubk15 and others added 4 commits August 27, 2025 20:43
@Jakubk15 @Rollczi
Update eternalcore-core/src/main/java/com/eternalcode/core/feature/sl…
1de082e 
…eep/PhantomSpawnController.java

Co-authored-by: Norbert Dejlich <[email protected]>
@Jakubk15 @Rollczi
Update eternalcore-core/src/main/java/com/eternalcode/core/feature/sl…
38f7704 
…eep/PlayerJoinSleepController.java

Co-authored-by: Norbert Dejlich <[email protected]>
@Jakubk15 @Rollczi
Update eternalcore-core/src/main/java/com/eternalcode/core/feature/sl…
477acf2 
…eep/PhantomSpawnController.java

Co-authored-by: Norbert Dejlich <[email protected]>
@Jakubk15
inline field
97554ef
@Jakubk15 Jakubk15 requested a review from Rollczi August 27, 2025 18:48
Jakubk15 and others added 2 commits September 2, 2025 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rollczi Rollczi Rollczi approved these changes

@vLuckyyy vLuckyyy vLuckyyy approved these changes

@igoyek igoyek igoyek approved these changes

@P1otrulla P1otrulla P1otrulla approved these changes

@CitralFlo CitralFlo CitralFlo approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@Jakubk15 Jakubk15

Labels
🚀 EternalCore 2.0 Major rework and refactor for the upcoming EternalCore 2.0 release 🆕 feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Permission that allows to ignore the holder sleeping to skip the night
6 participants
@Jakubk15 @Rollczi @vLuckyyy @igoyek @P1otrulla @CitralFlo