GH-134 GH-153 Fix Wrong replacement, remove chatformatter.legacycolor permission

[vLuckyyy]

Fixes: GH-134 GH-153

2025-06-17_20-31-36.mp4

[coderabbitai]

Walkthrough

The update clarifies the README permissions, showing that color and decoration permissions cover both old-style codes (like &c) and new MiniMessage tags (like ). The code now carefully checks if a user has permission for each legacy color or decoration code before applying it, using new methods that link codes to permissions. The build script removes one outdated permission node. Overall, the changes tidy up how legacy colors are handled and make permissions clearer and more precise.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6b26127 and c9393d2.

📒 Files selected for processing (1)

• chatformatter-core/src/main/java/com/eternalcode/formatter/ChatHandlerImpl.java (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• chatformatter-core/src/main/java/com/eternalcode/formatter/ChatHandlerImpl.java

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: build

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 3

🧹 Nitpick comments (2)

chatformatter-core/src/main/java/com/eternalcode/formatter/legacy/Legacy.java (1)

150-175: Un-permitted codes stay as “&x” – potential double parsing

selectiveLegacyToAdventure keeps disallowed codes in the string as &<code>.
Down-stream processors (MiniMessage pre-processors, etc.) might still translate them, undoing the permission check.

A quick fix is to strip them completely when not allowed:

-            return "&" + color;
+            return "";

That fully removes the styling attempt instead of giving it a second chance.

README.md (1)

59-75: Tiny nit – “etc.” could be explicit

For chatformatter.color.* you may list “all MiniMessage colour tags and legacy & codes” instead of “etc.” to mirror the explicit style used elsewhere.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 87e82b2 and 6b26127.

📒 Files selected for processing (4)

• README.md (2 hunks)
• chatformatter-core/src/main/java/com/eternalcode/formatter/ChatHandlerImpl.java (1 hunks)
• chatformatter-core/src/main/java/com/eternalcode/formatter/legacy/Legacy.java (3 hunks)
• chatformatter-paper-plugin/build.gradle.kts (0 hunks)

💤 Files with no reviewable changes (1)

• chatformatter-paper-plugin/build.gradle.kts

🔇 Additional comments (2)

chatformatter-core/src/main/java/com/eternalcode/formatter/legacy/Legacy.java (1)

177-189: Wildcard helper looks good

The helper is concise and re-usable. 👍

README.md (1)

37-47: Great clarification

The note and table now make the colour/deco mapping crystal-clear. Nice!

[CitralFlo]

fuck legacy <3

If it was tested with perms the code looks perfect