doc: verifier's responsibility #86
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrain
requested review from
akonring,
alxiong and
philippecamacho
as code owners
alxiong
reviewed
Sep 26, 2025
| - Verify that the `bmt_commitment` comes from a trusted source, e.g. the HotShot on-chain light client. | ||
| - Validate that the `vid_pp_hash` matches the public parameter of the Verifiable Information Dispersal (VID) scheme used by the Espresso sequencer. | ||
|
|
||
| > **Security Note:** Accepting a valid proof with invalid public inputs can lead to consensus failures, state corruption, or security vulnerabilities. Always perform strict checks on all public input fields. |
Comment on lines
+78
to
+82
| 2. **Check Public Input Validity**: | ||
| - Confirm that the `rollup_txs_commit` is well-formed and matches the expected rollup transactions. | ||
| - Ensure that the `ns_id` is the expected namespace ID. | ||
| - Verify that the `bmt_commitment` comes from a trusted source, e.g. the HotShot on-chain light client. | ||
| - Validate that the `vid_pp_hash` matches the public parameter of the Verifiable Information Dispersal (VID) scheme used by the Espresso sequencer. |
There was a problem hiding this comment.
i think we should reorder. also be more explicit about "how to check" or "what to do"
- check
ns_idshould probably be the logically first thing - should
vid_ppandbmt_commbe fetched by some espresso RPC or public endpoint, if so, we should list them (@jbearer do you know?) - then explicitly says that
rollup_tx_commitshould match the field in the public inputs of the zkVM execution proof. The field that commits to the entire batch of tx being proven.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #<ISSUE_NUMBER>
This PR:
This PR does not:
Key places to review: